From a7e070077dd67ba68991f73304312a18385eacb2 Mon Sep 17 00:00:00 2001 From: Shangtong Zhang Date: Tue, 12 Jun 2018 21:52:15 -0600 Subject: [PATCH] Fix a bug of Huber loss --- deep_rl/agent/QuantileRegressionDQN_agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deep_rl/agent/QuantileRegressionDQN_agent.py b/deep_rl/agent/QuantileRegressionDQN_agent.py index a23faf2..da2b7b5 100644 --- a/deep_rl/agent/QuantileRegressionDQN_agent.py +++ b/deep_rl/agent/QuantileRegressionDQN_agent.py @@ -28,7 +28,7 @@ class QuantileRegressionDQNAgent(BaseAgent): (2 * np.arange(self.config.num_quantiles) + 1) / (2.0 * self.config.num_quantiles)) def huber(self, x): - cond = (x < 1.0).float().detach() + cond = (x.abs() < 1.0).float().detach() return 0.5 * x.pow(2) * cond + (x.abs() - 0.5) * (1 - cond) def evaluation_action(self, state):