From 1f81058cebc7967c01a09c38d131a5d1f6ec0612 Mon Sep 17 00:00:00 2001 From: Arnar Gauti Ingason Date: Wed, 29 Jul 2015 17:23:39 +0000 Subject: [PATCH 1/2] Adding all available options to the BrowserWindowOptions interface --- github-electron/github-electron.d.ts | 45 ++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/github-electron/github-electron.d.ts b/github-electron/github-electron.d.ts index 4e1e289ca..617f32bd9 100644 --- a/github-electron/github-electron.d.ts +++ b/github-electron/github-electron.d.ts @@ -456,8 +456,53 @@ declare module GitHubElectron { isVisibleOnAllWorkspaces(): boolean; } + // Includes all options BrowserWindow can take as of this writing + // http://electron.atom.io/docs/v0.29.0/api/browser-window/ interface BrowserWindowOptions extends Rectangle { show?: boolean; + 'use-content-size'?: boolean; + center?: boolean; + 'min-width'?: number; + 'min-height'?: number; + 'max-width'?: number; + 'max-height'?: number; + resizable?: boolean; + 'always-on-top'?: boolean; + fullscreen?: boolean; + 'skip-taskbar'?: boolean; + 'zoom-factor'?: number; + kiosk?: boolean; + title?: string; + icon?: NativeImage; + frame?: boolean; + 'node-integration'?: boolean; + 'accept-first-mouse'?: boolean; + 'disable-auto-hide-cursor'?: boolean; + 'auto-hide-menu-bar'?: boolean; + 'enable-larger-than-screen'?: boolean; + 'dark-theme'?: boolean; + preload?: string; + transparent?: boolean; + type?: string; + 'standard-window'?: boolean; + 'web-preferences'?: any; // Object + javascript?: boolean; + 'web-security'?: boolean; + images?: boolean; + java?: boolean; + 'text-areas-are-resizable'?: boolean; + webgl?: boolean; + webaudio?: boolean; + plugins?: boolean; + 'extra-plugin-dirs'?: string[]; + 'experimental-features'?: boolean; + 'experimental-canvas-features'?: boolean; + 'subpixel-font-scaling'?: boolean; + 'overlay-scrollbars'?: boolean; + 'overlay-fullscreen-video'?: boolean; + 'shared-worker'?: boolean; + 'direct-write'?: boolean; + 'page-visibility'?: boolean; } interface Rectangle { From 85ed51e0e3c0a0b31283dc1745194d3925e401e1 Mon Sep 17 00:00:00 2001 From: Arnar Gauti Ingason Date: Wed, 29 Jul 2015 17:38:24 +0000 Subject: [PATCH 2/2] Icon should allow NativeImage or string --- github-electron/github-electron.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/github-electron/github-electron.d.ts b/github-electron/github-electron.d.ts index 617f32bd9..c184ee7cf 100644 --- a/github-electron/github-electron.d.ts +++ b/github-electron/github-electron.d.ts @@ -473,7 +473,7 @@ declare module GitHubElectron { 'zoom-factor'?: number; kiosk?: boolean; title?: string; - icon?: NativeImage; + icon?: NativeImage|string; frame?: boolean; 'node-integration'?: boolean; 'accept-first-mouse'?: boolean;