diff --git a/request/request-tests.ts b/request/request-tests.ts index 30ca3226d..9fd6437cd 100644 --- a/request/request-tests.ts +++ b/request/request-tests.ts @@ -110,6 +110,15 @@ var options: request.Options = { strictSSL: bool }; +// Below line has compile error, use OptionsWithUri or OptionsWithUrl instead. See #7979. +// options.uri = str; + +const opt: request.OptionsWithUri = { + baseUrl: 'http://localhost', + uri: 'bar' +}; +opt.uri = str; + // --- --- --- --- --- --- --- --- --- --- --- --- agent = req.getAgent(); diff --git a/request/request.d.ts b/request/request.d.ts index f47a9ddaa..72eed1e7b 100644 --- a/request/request.d.ts +++ b/request/request.d.ts @@ -125,7 +125,10 @@ declare module 'request' { uri?: string; url?: string; } - export type Options = RequiredUriUrl & CoreOptions; + + export type OptionsWithUri = UriOptions & CoreOptions; + export type OptionsWithUrl = UrlOptions & CoreOptions; + export type Options = OptionsWithUri | OptionsWithUrl; export interface RequestCallback { (error: any, response: http.IncomingMessage, body: any): void;