From 15c1672d82b6c714eddafa97c85f193e7efcd497 Mon Sep 17 00:00:00 2001 From: Theodore Brown Date: Fri, 23 Aug 2013 12:24:26 -0500 Subject: [PATCH 1/3] Updated spin.js definition for v1.3.1 of the library --- spin/spin.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spin/spin.d.ts b/spin/spin.d.ts index e92e42ca9..6ebba2f0c 100644 --- a/spin/spin.d.ts +++ b/spin/spin.d.ts @@ -1,4 +1,4 @@ -// Type definitions for Spin.js 1.3 +// Type definitions for Spin.js 1.3.1 // Project: http://fgnass.github.com/spin.js/ // Definitions by: Boris Yankov and Theodore Brown // Definitions: https://github.com/borisyankov/DefinitelyTyped @@ -12,7 +12,7 @@ interface SpinnerOptions { corners?: number; // Corner roundness (0..1) rotate?: number; // The rotation offset direction?: number; // 1: clockwise, -1: counterclockwise - color?: string; // #rgb or #rrggbb + color?: any; // #rgb or #rrggbb or array of colors speed?: number; // Rounds per second trail?: number; // Afterglow percentage shadow?: boolean; // Whether to render a shadow From 6d947d909ba570a7b139117c4584b3941abdbb19 Mon Sep 17 00:00:00 2001 From: Theodore Brown Date: Fri, 23 Aug 2013 12:24:44 -0500 Subject: [PATCH 2/3] Normalized spin.js defninition line endings --- spin/spin.d.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/spin/spin.d.ts b/spin/spin.d.ts index 6ebba2f0c..b6a7d37f8 100644 --- a/spin/spin.d.ts +++ b/spin/spin.d.ts @@ -29,16 +29,16 @@ declare class Spinner { public el: HTMLElement; constructor(options?: SpinnerOptions); - /** - * Adds the spinner to the given target element. If this instance is already - * spinning, it is automatically removed from its previous target by calling - * stop() internally. + /** + * Adds the spinner to the given target element. If this instance is already + * spinning, it is automatically removed from its previous target by calling + * stop() internally. */ spin(target?: any): Spinner; - /** - * Stops and removes the Spinner. - * Stopped spinners may be reused by calling spin() again. + /** + * Stops and removes the Spinner. + * Stopped spinners may be reused by calling spin() again. */ stop(): Spinner; lines(el, o); From e3f3a34bd7c1fe0044674d1bfcc2b0825e2ac25c Mon Sep 17 00:00:00 2001 From: Theodore Brown Date: Fri, 23 Aug 2013 12:25:04 -0500 Subject: [PATCH 3/3] Expanded spin.js tests to cover each option --- spin/spin-tests.ts | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/spin/spin-tests.ts b/spin/spin-tests.ts index afc070646..b72a2da01 100644 --- a/spin/spin-tests.ts +++ b/spin/spin-tests.ts @@ -4,5 +4,27 @@ var spinner = new Spinner().spin(); target.appendChild(spinner.el); var target = document.getElementById('foo'); -var opts = { speed: 5, className: 'awesome' }; -var spinner2 = new Spinner(opts).spin(target); \ No newline at end of file +var opts = { speed: 5, color: '#abcdef' }; +var spinner2 = new Spinner(opts).spin(target); + +var opts2 = { + lines: 10, + length: 20, + width: 7, + radius: 14, + corners: 0.6, + rotate: 0, + direction: 1, + color: ['#aaa', '#fedcba', '#fff', '#aef02b'], + speed: 1.5, + trail: 50, + shadow: true, + hwaccel: true, + className: 'spinner', + zIndex: 5, + top: '28', + left: 'auto' +}; + +var newTarget = document.getElementById('bar'); +var spinner3 = new Spinner(opts2).spin(newTarget);