From 5922a58bf11b65c5866b8b9ec654d1dbb8903915 Mon Sep 17 00:00:00 2001 From: kwiateusz Date: Wed, 23 Dec 2015 14:28:50 +0100 Subject: [PATCH 1/2] Updated IonicPopoverController interface Added method remove based on documentation --- ionic/ionic.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/ionic/ionic.d.ts b/ionic/ionic.d.ts index a3781f26d..a767b851b 100644 --- a/ionic/ionic.d.ts +++ b/ionic/ionic.d.ts @@ -238,6 +238,7 @@ declare module ionic { show($event?: any): ng.IPromise; hide(): ng.IPromise; isShown(): boolean; + remove(): ng.IPromise; } interface IonicPopoverOptions { scope?: any; From 969afec63e373e71323e217b4badb0ed9b6df5af Mon Sep 17 00:00:00 2001 From: kwiateusz Date: Wed, 23 Dec 2015 15:00:35 +0100 Subject: [PATCH 2/2] Added test for remove method --- ionic/ionic-tests.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ionic/ionic-tests.ts b/ionic/ionic-tests.ts index bad5f9d9f..8491fc13f 100644 --- a/ionic/ionic-tests.ts +++ b/ionic/ionic-tests.ts @@ -200,8 +200,9 @@ class IonicTestController { }; var ionicPopoverController: ionic.popover.IonicPopoverController = this.$ionicPopover.fromTemplate("template", popoverOptions); ionicPopoverController.initialize(popoverOptions); - ionicPopoverController.show(angular.element("body")).then(() => console.log("shown popover")) - ionicPopoverController.hide().then(() => console.log("hid popover")) + ionicPopoverController.show(angular.element("body")).then(() => console.log("shown popover")); + ionicPopoverController.hide().then(() => console.log("hid popover")); + ionicPopoverController.remove().then(() => console.log("removed popover")); var isShown: boolean = ionicPopoverController.isShown(); this.$ionicPopover.fromTemplateUrl("templateUrl", popoverOptions)