From 0143f1c13a3d5930dbbb1397f4773e1942332147 Mon Sep 17 00:00:00 2001 From: Timothy Boyce Date: Sun, 2 Aug 2015 17:25:26 +0000 Subject: [PATCH 1/2] Update angular-localForage.d.ts Correct the signature and return type for bind --- angular-localForage/angular-localForage.d.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/angular-localForage/angular-localForage.d.ts b/angular-localForage/angular-localForage.d.ts index ee2aeeb6d..6186d79d3 100644 --- a/angular-localForage/angular-localForage.d.ts +++ b/angular-localForage/angular-localForage.d.ts @@ -46,14 +46,14 @@ declare module angular.localForage { iterate(iteratorCallback:(value:string | number, key:string)=>T):angular.IPromise; - bind($scope:ng.IScope, key:string):void; + bind($scope:ng.IScope, key:string):angular.IPromise; bind($scope:ng.IScope, config:{ key:string; - defaultValue:any; - scopeKey:string; - name:string; - }):void; + defaultValue?:any; + scopeKey?:string; + name?:string; + }):angular.IPromise; unbind($scope:ng.IScope, key:string, scopeKey?:string):void; From 8155d032f3629412ed5cccab6339a9347df4bcd6 Mon Sep 17 00:00:00 2001 From: Timothy Boyce Date: Sun, 2 Aug 2015 17:48:02 +0000 Subject: [PATCH 2/2] update angular-localForage-tests.ts --- angular-localForage/angular-localForage-tests.ts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/angular-localForage/angular-localForage-tests.ts b/angular-localForage/angular-localForage-tests.ts index 8b31143c2..3ea776ebf 100644 --- a/angular-localForage/angular-localForage-tests.ts +++ b/angular-localForage/angular-localForage-tests.ts @@ -124,3 +124,18 @@ $localForage.iterate(function (value, key) { } }).then(function (data) { }); + +$localForage.bind($rootScope, 'key').then(function(data) { +}); + +$localForage.bind($rootScope, {key: 'key'}).then(function(data) { +}); + +$localForage.bind($rootScope, {key: 'key', defaultValue: 'defaultValue'}).then(function(data) { +}); + +$localForage.bind($rootScope, {key: 'key', scopeKey: 'scopeKey'}).then(function(data) { +}); + +$localForage.bind($rootScope, {key: 'key', name: 'name'}).then(function(data) { +});