From 458b73bddd5bd6306390b312dfc02bd17360b46d Mon Sep 17 00:00:00 2001 From: Christopher Glantschnig Date: Wed, 24 Jun 2015 20:37:49 +0200 Subject: [PATCH 1/3] added definitions for request-promise --- request-promise/request-promise.d.ts | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 request-promise/request-promise.d.ts diff --git a/request-promise/request-promise.d.ts b/request-promise/request-promise.d.ts new file mode 100644 index 000000000..b2a6f2da2 --- /dev/null +++ b/request-promise/request-promise.d.ts @@ -0,0 +1,28 @@ +// Type definitions for request-promise (v0.4.2) +// Definitions by: Christopher Glantschnig + +/// +/// +/// +/// + +declare module 'request-promise' { + import request = require('request'); + import stream = require('stream'); + import http = require('http'); + import FormData = require('form-data'); + + export = RequestPromiseAPI; + + function RequestPromiseAPI(uri: string, options?: RequestPromiseAPI.Options): Promise; + function RequestPromiseAPI(uri: string): Promise; + function RequestPromiseAPI(options: RequestPromiseAPI.Options, callback?: (error: any, response: http.IncomingMessage, body: any) => void): request.Request; + + module RequestPromiseAPI { + export interface Options extends request.Options { + simple?: boolean; + transform?: (body: any, response: http.IncomingMessage) => number; + resolveWithFullResponse?: boolean; + } + } +} From a619d54c4fb4b0dde0d578f071a719c1ddf196d9 Mon Sep 17 00:00:00 2001 From: Christopher Glantschnig Date: Wed, 24 Jun 2015 20:57:15 +0200 Subject: [PATCH 2/3] added tests and updated header according to contribution guidelines --- request-promise/request-promise-tests.ts | 17 +++++++++++++++++ request-promise/request-promise.d.ts | 9 +++++---- 2 files changed, 22 insertions(+), 4 deletions(-) create mode 100644 request-promise/request-promise-tests.ts diff --git a/request-promise/request-promise-tests.ts b/request-promise/request-promise-tests.ts new file mode 100644 index 000000000..41a5eb80d --- /dev/null +++ b/request-promise/request-promise-tests.ts @@ -0,0 +1,17 @@ +/// + +import rp = require('request-promise'); + +rp('http://www.google.com') + .then(console.dir) + .catch(console.error); + +var options: rp.Options = { + uri : 'http://posttestserver.com/post.php', + method : 'POST' +}; + +rp(options) + .then(console.dir) + .catch(console.error); + diff --git a/request-promise/request-promise.d.ts b/request-promise/request-promise.d.ts index b2a6f2da2..bdc2764a2 100644 --- a/request-promise/request-promise.d.ts +++ b/request-promise/request-promise.d.ts @@ -1,5 +1,7 @@ -// Type definitions for request-promise (v0.4.2) -// Definitions by: Christopher Glantschnig +// Type definitions for request-promise v0.4.2 +// Project: https://www.npmjs.com/package/request-promise +// Definitions by: Christopher Glantschnig +// Definitions: https://github.com/borisyankov/DefinitelyTyped /// /// @@ -14,9 +16,8 @@ declare module 'request-promise' { export = RequestPromiseAPI; - function RequestPromiseAPI(uri: string, options?: RequestPromiseAPI.Options): Promise; + function RequestPromiseAPI(options: RequestPromiseAPI.Options): request.Request; function RequestPromiseAPI(uri: string): Promise; - function RequestPromiseAPI(options: RequestPromiseAPI.Options, callback?: (error: any, response: http.IncomingMessage, body: any) => void): request.Request; module RequestPromiseAPI { export interface Options extends request.Options { From 9e69de89d1124ddf1a07874dc383fcbb2a0b64b2 Mon Sep 17 00:00:00 2001 From: Christopher Glantschnig Date: Thu, 25 Jun 2015 18:29:57 +0200 Subject: [PATCH 3/3] fixed return type according to the tests --- request-promise/request-promise.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/request-promise/request-promise.d.ts b/request-promise/request-promise.d.ts index bdc2764a2..9cee53eee 100644 --- a/request-promise/request-promise.d.ts +++ b/request-promise/request-promise.d.ts @@ -16,7 +16,7 @@ declare module 'request-promise' { export = RequestPromiseAPI; - function RequestPromiseAPI(options: RequestPromiseAPI.Options): request.Request; + function RequestPromiseAPI(options: RequestPromiseAPI.Options): Promise; function RequestPromiseAPI(uri: string): Promise; module RequestPromiseAPI {