From ae8cc62b357e25cd55cd3133eadd34632c95dc06 Mon Sep 17 00:00:00 2001 From: Honza Dvorsky Date: Thu, 2 Apr 2015 15:14:50 +0200 Subject: [PATCH 1/5] on-finished typings --- on-finished/on-finished.d.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 on-finished/on-finished.d.ts diff --git a/on-finished/on-finished.d.ts b/on-finished/on-finished.d.ts new file mode 100644 index 000000000..b3916f513 --- /dev/null +++ b/on-finished/on-finished.d.ts @@ -0,0 +1,10 @@ +// Type definitions for on-finished v2.2.0 +// Project: https://github.com/jshttp/on-finished +// Definitions by: Honza Dvorsky +// Definitions: https://github.com/borisyankov/DefinitelyTyped + +declare module 'on-finished' { + + export function onFinished(msg:any, listener:Function):any; + export function isFinished(msg:any):boolean; +} From d7e1bba687a3d947e681376ba963c2204e3dd71a Mon Sep 17 00:00:00 2001 From: Honza Dvorsky Date: Thu, 2 Apr 2015 19:32:47 +0200 Subject: [PATCH 2/5] adding on-finished tests --- on-finished/on-finished-tests.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 on-finished/on-finished-tests.ts diff --git a/on-finished/on-finished-tests.ts b/on-finished/on-finished-tests.ts new file mode 100644 index 000000000..8e2b4734b --- /dev/null +++ b/on-finished/on-finished-tests.ts @@ -0,0 +1,12 @@ +/// + +function test_finished() { + + var msg = {}; + + var ret = onFinished(msg, () => { + //callback + }); + + var finished: boolean = isFinished(msg); +} From 145e8af07a0120fb82c83b493d5adbde895c6cb7 Mon Sep 17 00:00:00 2001 From: Honza Dvorsky Date: Thu, 2 Apr 2015 20:13:08 +0200 Subject: [PATCH 3/5] on-finished fixed tests --- on-finished/on-finished-tests.ts | 11 +++++++---- on-finished/on-finished.d.ts | 8 +++++--- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/on-finished/on-finished-tests.ts b/on-finished/on-finished-tests.ts index 8e2b4734b..15a757718 100644 --- a/on-finished/on-finished-tests.ts +++ b/on-finished/on-finished-tests.ts @@ -1,12 +1,15 @@ -/// +/// +/// + +import events = require('events'); function test_finished() { - var msg = {}; + var e = new events.EventEmitter(); - var ret = onFinished(msg, () => { + var ret: NodeJS.EventEmitter = OnFinished.onFinished(e, () => { //callback }); - var finished: boolean = isFinished(msg); + var finished: boolean = OnFinished.isFinished(e); } diff --git a/on-finished/on-finished.d.ts b/on-finished/on-finished.d.ts index b3916f513..e4e35c995 100644 --- a/on-finished/on-finished.d.ts +++ b/on-finished/on-finished.d.ts @@ -3,8 +3,10 @@ // Definitions by: Honza Dvorsky // Definitions: https://github.com/borisyankov/DefinitelyTyped -declare module 'on-finished' { +/// - export function onFinished(msg:any, listener:Function):any; - export function isFinished(msg:any):boolean; +declare module OnFinished { + + export function onFinished(msg:NodeJS.EventEmitter, listener:Function): NodeJS.EventEmitter; + export function isFinished(msg:NodeJS.EventEmitter):boolean; } From 11e9b11d5e6b4c8f32eb515525eb6fece52881ad Mon Sep 17 00:00:00 2001 From: Honza Dvorsky Date: Thu, 2 Apr 2015 20:26:16 +0200 Subject: [PATCH 4/5] fix to match the name of the module --- on-finished/on-finished-tests.ts | 1 + on-finished/on-finished.d.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/on-finished/on-finished-tests.ts b/on-finished/on-finished-tests.ts index 15a757718..455ee2923 100644 --- a/on-finished/on-finished-tests.ts +++ b/on-finished/on-finished-tests.ts @@ -2,6 +2,7 @@ /// import events = require('events'); +import OnFinished = require('on-finished'); function test_finished() { diff --git a/on-finished/on-finished.d.ts b/on-finished/on-finished.d.ts index e4e35c995..b595b9012 100644 --- a/on-finished/on-finished.d.ts +++ b/on-finished/on-finished.d.ts @@ -5,7 +5,7 @@ /// -declare module OnFinished { +declare module 'on-finished' { export function onFinished(msg:NodeJS.EventEmitter, listener:Function): NodeJS.EventEmitter; export function isFinished(msg:NodeJS.EventEmitter):boolean; From c20dc7f503c50e70ca60cbd2ebe30a686d7d22ad Mon Sep 17 00:00:00 2001 From: Honza Dvorsky Date: Fri, 3 Apr 2015 03:09:09 +0200 Subject: [PATCH 5/5] finally figured out how to have a callable module with extra functions --- on-finished/on-finished-tests.ts | 6 +++--- on-finished/on-finished.d.ts | 10 ++++++++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/on-finished/on-finished-tests.ts b/on-finished/on-finished-tests.ts index 455ee2923..c3956ac6b 100644 --- a/on-finished/on-finished-tests.ts +++ b/on-finished/on-finished-tests.ts @@ -2,15 +2,15 @@ /// import events = require('events'); -import OnFinished = require('on-finished'); +import onFinished = require('on-finished'); function test_finished() { var e = new events.EventEmitter(); - var ret: NodeJS.EventEmitter = OnFinished.onFinished(e, () => { + var ret: NodeJS.EventEmitter = onFinished(e, () => { //callback }); - var finished: boolean = OnFinished.isFinished(e); + var finished: boolean = onFinished.isFinished(e); } diff --git a/on-finished/on-finished.d.ts b/on-finished/on-finished.d.ts index b595b9012..0ca4f2286 100644 --- a/on-finished/on-finished.d.ts +++ b/on-finished/on-finished.d.ts @@ -5,8 +5,14 @@ /// + declare module 'on-finished' { - export function onFinished(msg:NodeJS.EventEmitter, listener:Function): NodeJS.EventEmitter; - export function isFinished(msg:NodeJS.EventEmitter):boolean; + function onFinished(msg:NodeJS.EventEmitter, listener:Function): NodeJS.EventEmitter; + + module onFinished { + export function isFinished(msg:NodeJS.EventEmitter):boolean; + } + + export = onFinished; }