From 3387b8b71553573ec44125b9daf81d9c6e22efa9 Mon Sep 17 00:00:00 2001 From: pafflique Date: Tue, 7 Jul 2015 16:57:09 +0300 Subject: [PATCH 1/2] Collection.add signature fix http://backbonejs.org/#Collection-add - "Returns the added (or preexisting, if duplicate) models." --- backbone/backbone.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backbone/backbone.d.ts b/backbone/backbone.d.ts index 9d54361d5..b9039be35 100644 --- a/backbone/backbone.d.ts +++ b/backbone/backbone.d.ts @@ -181,8 +181,8 @@ declare module Backbone { comparator(element: TModel): number; comparator(compare: TModel, to?: TModel): number; - add(model: TModel, options?: AddOptions): Collection; - add(models: TModel[], options?: AddOptions): Collection; + add(model: TModel, options?: AddOptions): TModel; + add(models: TModel[], options?: AddOptions): TModel[]; at(index: number): TModel; /** * Get a model from a collection, specified by an id, a cid, or by passing in a model. From 70761a5ae8f624f2ce3517540a93bc68de5f3f4c Mon Sep 17 00:00:00 2001 From: pafflique Date: Tue, 7 Jul 2015 17:11:04 +0300 Subject: [PATCH 2/2] Allow mixed content in Collection.add Valid for TypeScript 1.4 --- backbone/backbone.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backbone/backbone.d.ts b/backbone/backbone.d.ts index b9039be35..275dba237 100644 --- a/backbone/backbone.d.ts +++ b/backbone/backbone.d.ts @@ -181,8 +181,8 @@ declare module Backbone { comparator(element: TModel): number; comparator(compare: TModel, to?: TModel): number; - add(model: TModel, options?: AddOptions): TModel; - add(models: TModel[], options?: AddOptions): TModel[]; + add(model: {}|TModel, options?: AddOptions): TModel; + add(models: ({}|TModel)[], options?: AddOptions): TModel[]; at(index: number): TModel; /** * Get a model from a collection, specified by an id, a cid, or by passing in a model.