From 6fd7cc3451e464303a8f003cb39171f30585996c Mon Sep 17 00:00:00 2001 From: vvakame Date: Sat, 27 Feb 2016 01:49:16 +0900 Subject: [PATCH] add Issue and Pull Request templates --- ISSUE_TEMPLATE.md | 5 +++++ PULL_REQUEST_TEMPLATE.md | 8 ++++++++ 2 files changed, 13 insertions(+) create mode 100644 ISSUE_TEMPLATE.md create mode 100644 PULL_REQUEST_TEMPLATE.md diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md new file mode 100644 index 000000000..67422ac5b --- /dev/null +++ b/ISSUE_TEMPLATE.md @@ -0,0 +1,5 @@ +- [ ] I tried using the latest `xxxx/xxxx.d.ts` file in this repo and had problems. +- [ ] I tried using the latest stable version of tsc. https://www.npmjs.com/package/typescript +- [ ] My question is inappropriate for StackOverflow. +- [ ] I want to talk about `xxxx/xxxx.d.ts`. + - The authors of that type definition are cc/ @.... diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..730bd78af --- /dev/null +++ b/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,8 @@ +case 1. Add a new type definition. +- [ ] checked compilation succeeds with `--target es6` and `--noImplicitAny` options. +- [ ] has correct [naming convention](http://definitelytyped.org/guides/contributing.html#naming-the-file) +- [ ] has a [test file](http://definitelytyped.org/guides/contributing.html#tests) with the suffix of `-tests.ts` or `-tests.tsx`. + +case 2. Improvement to existing type definition. +- documentation or source code reference which provides context for the suggested changes. url http://api.jquery.com/html . + - it has been reviewed by a DefinitelyTyped member.