From 653653dfaac4bb260163410b684fae0ae1898758 Mon Sep 17 00:00:00 2001 From: John Reilly Date: Tue, 5 Nov 2013 12:17:20 +0000 Subject: [PATCH 1/2] Knockout:Removed non-generic overloads from utils As far as I can tell these no longer fulfil a purpose and aren't needed for backward compatibility. As an aside they appear to currently confuse the TypeScript compiler as well (see https://typescript.codeplex.com/workitem/1865 ) --- knockout/knockout.d.ts | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/knockout/knockout.d.ts b/knockout/knockout.d.ts index 63f993894..7759f4190 100644 --- a/knockout/knockout.d.ts +++ b/knockout/knockout.d.ts @@ -235,36 +235,22 @@ interface KnockoutUtils { arrayForEach(array: T[], action: (item: T) => void): void; - arrayForEach(array: any[], action: (any) => void ): void; - arrayIndexOf(array: any[], item: any): number; arrayFirst(array: T[], predicate: (item: T) => boolean, predicateOwner?: any): T; - arrayFirst(array: any[], predicate: (item) => boolean, predicateOwner?: any): any; - arrayRemoveItem(array: any[], itemToRemove: any): void; arrayGetDistinctValues(array: T[]): T[]; - arrayGetDistinctValues(array: any[]): any[]; - arrayMap(array: T[], mapping: (item: T) => U): U[]; - arrayMap(array: any[], mapping: (item) => any): any[]; - arrayFilter(array: T[], predicate: (item: T) => boolean): T[]; - arrayFilter(array: any[], predicate: (item) => boolean): any[]; - arrayPushAll(array: T[], valuesToPush: T[]): T[]; - arrayPushAll(array: any[], valuesToPush: any[]): any[]; - arrayPushAll(array: KnockoutObservableArray, valuesToPush: T[]): T[]; - arrayPushAll(array: KnockoutObservableArray, valuesToPush: any[]): any[]; - extend(target, source); emptyDomNode(domNode): void; From b63705a0ca34869bcb63791a551943c9096bdc02 Mon Sep 17 00:00:00 2001 From: John Reilly Date: Tue, 5 Nov 2013 14:32:55 +0000 Subject: [PATCH 2/2] Globalize: reduced the number of implicit anys --- globalize/globalize-tests.ts | 8 ++++++-- globalize/globalize.d.ts | 14 ++++++++------ 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/globalize/globalize-tests.ts b/globalize/globalize-tests.ts index 577330424..5174f90f9 100644 --- a/globalize/globalize-tests.ts +++ b/globalize/globalize-tests.ts @@ -22,10 +22,14 @@ Globalize.addCultureInfo("fr", { messages: { "translate": "traduire" } }); console.log(Globalize.localize("translate", "fr")); Globalize.parseInt("1,234.56"); -Globalize.parseInt("1.234,56"); +Globalize.parseInt("1.234,56", 10); +Globalize.parseInt("1.234,56", 10, "de"); Globalize.parseFloat("1,234.56"); -Globalize.parseFloat("1.234,56"); +Globalize.parseFloat("1.234,56", 10); +Globalize.parseFloat("1.234,56", 10, "de"); Globalize.parseDate("1/2/2003"); +Globalize.parseDate("15 Jun 2012", "dd MMM yyyy"); +Globalize.parseDate("15 Jun 2012", ["dd MMM yyyy"]); Globalize.culture("fr"); Globalize.parseDate("1/2/2003"); diff --git a/globalize/globalize.d.ts b/globalize/globalize.d.ts index dd2876bc8..da17957f1 100644 --- a/globalize/globalize.d.ts +++ b/globalize/globalize.d.ts @@ -107,14 +107,16 @@ interface GlobalizeStatic { culture(cultureSelector: string): GlobalizeCulture; culture(cultureSelector: string[]): GlobalizeCulture; - addCultureInfo(cultureName, baseCultureName, info? ); + addCultureInfo(cultureName: string, baseCultureName, info?); findClosestCulture(cultureSelector: string); - format(value, format, cultureSelector? ); - localize(key, cultureSelector?); + format(value: number, format: string, cultureSelector?: string); + format(value: Date, format: string, cultureSelector?: string); + localize(key: string, cultureSelector?: string); - parseDate(value: string, formats? , cultureSelector?: string): Date; - parseInt(value: string, radix? , cultureSelector?: string): number; - parseFloat(value: string, radix? , cultureSelector?: string): number; + parseDate(value: string, format?: string, cultureSelector?: string): Date; + parseDate(value: string, formats?: string[], cultureSelector?: string): Date; + parseInt(value: string, radix?: number, cultureSelector?: string): number; + parseFloat(value: string, radix?: number, cultureSelector?: string): number; } declare var Globalize: GlobalizeStatic;