From 9439dc4ab093788829067802c0fdff0e21fbce70 Mon Sep 17 00:00:00 2001 From: Nathan Pitman Date: Tue, 12 May 2015 17:07:03 +1200 Subject: [PATCH 1/2] Fixed nullability in qtip2.d.ts. Fixed style tests in qtip2-tests.ts --- qtip2/qtip2-tests.ts | 8 ++++---- qtip2/qtip2.d.ts | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/qtip2/qtip2-tests.ts b/qtip2/qtip2-tests.ts index ea4e16099..144b4aa51 100644 --- a/qtip2/qtip2-tests.ts +++ b/qtip2/qtip2-tests.ts @@ -398,7 +398,7 @@ function testStyleProperty() { }); $a.qtip({ - show: { + style: { classes: false, width: 24, height: 24, @@ -407,7 +407,7 @@ function testStyleProperty() { }); $a.qtip({ - show: { + style: { classes: false, width: false, height: false, @@ -423,7 +423,7 @@ function testStyleProperty() { }); $a.qtip({ - show: { + style: { tip: { corner: true, mimic: true, @@ -433,7 +433,7 @@ function testStyleProperty() { }); $a.qtip({ - show: { + style: { tip: { } } }); diff --git a/qtip2/qtip2.d.ts b/qtip2/qtip2.d.ts index 1691715b6..8d17544f1 100644 --- a/qtip2/qtip2.d.ts +++ b/qtip2/qtip2.d.ts @@ -98,8 +98,8 @@ declare module QTip2 { classes?: string | boolean; def?: boolean; widget?: boolean; - width: string | number | boolean; - height: string | number | boolean; + width?: string | number | boolean; + height?: string | number | boolean; tip?: string | boolean | Tip; } From f39cdea7ad90129418fdf5980f04aacc5952bf00 Mon Sep 17 00:00:00 2001 From: Nathan Pitman Date: Tue, 12 May 2015 17:08:33 +1200 Subject: [PATCH 2/2] Fix my contributor info in qtip2.d.ts and CONTRIBUTORS.md --- CONTRIBUTORS.md | 2 +- qtip2/qtip2.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 36bcdb307..a41d225ec 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -726,7 +726,7 @@ This document generated by [dt-contributors-generator](https://github.com/vvakam * [:link:](q-io/Q-io.d.ts) [Q-io](https://github.com/kriskowal/q-io) by [Bart van der Schoor](https://github.com/Bartvds) * [:link:](q-retry/q-retry.d.ts) [q-retry](https://github.com/vilic/q-retry) by [VILIC VANE](https://github.com/vilic) * [:link:](qajax/qajax.d.ts) [Qajax](https://github.com/gre/qajax) by [Boltmade](https://github.com/Boltmade) -* [:link:](qtip2/qtip2.d.ts) [qtip2](http://qtip2.com) by [Nathan Pitman](https://github.com/Seltzer100) +* [:link:](qtip2/qtip2.d.ts) [qtip2](http://qtip2.com) by [Nathan Pitman](https://github.com/Seltzer) * [:link:](qunit/qunit.d.ts) [QUnit](http://qunitjs.com) by [Diullei Gomes](https://github.com/diullei) * [:link:](rabbit.js/rabbit.js.d.ts) [rabbit.js](https://github.com/squaremo/rabbit.js) by [Wonshik Kim](https://github.com/wokim) * [:link:](ractive/ractive.d.ts) [Ractive](http://ractivejs.org) by [Han Lin Yap](http://yap.nu) diff --git a/qtip2/qtip2.d.ts b/qtip2/qtip2.d.ts index 8d17544f1..3d1f841f2 100644 --- a/qtip2/qtip2.d.ts +++ b/qtip2/qtip2.d.ts @@ -1,6 +1,6 @@ // Type definitions for qtip2 v2.2.1 // Project: http://qtip2.com/ -// Definitions by: Nathan Pitman +// Definitions by: Nathan Pitman // Definitions: https://github.com/borisyankov/DefinitelyTyped // Notes: // - Type bindings for the QTip2 API and options are included. Bindings for global settings aren't required.