From 0a82566305b4d16dd7bf1dda7a16dea1dfd505f6 Mon Sep 17 00:00:00 2001 From: eyaozhi Date: Thu, 10 Mar 2016 18:27:24 +0800 Subject: [PATCH 1/4] add agent parameter --- request/request-tests.ts | 1 + request/request.d.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/request/request-tests.ts b/request/request-tests.ts index 9fd6437cd..3586d0dee 100644 --- a/request/request-tests.ts +++ b/request/request-tests.ts @@ -92,6 +92,7 @@ var options: request.Options = { qs: obj, json: value, multipart: value, + agent: new http.Agent(), agentOptions: value, agentClass: value, forever: value, diff --git a/request/request.d.ts b/request/request.d.ts index b8506aceb..da1491687 100644 --- a/request/request.d.ts +++ b/request/request.d.ts @@ -86,6 +86,7 @@ declare module 'request' { qs?: any; json?: any; multipart?: RequestPart[] | Multipart; + agent?: http.Agent; agentOptions?: any; agentClass?: any; forever?: any; From 9bbebb466dcd3a6adcf6081f0627c04c251ce52b Mon Sep 17 00:00:00 2001 From: davidyaozw Date: Fri, 11 Mar 2016 11:56:12 +0800 Subject: [PATCH 2/4] Update request.d.ts fix according to review comment --- request/request.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/request/request.d.ts b/request/request.d.ts index da1491687..ba07bf4dd 100644 --- a/request/request.d.ts +++ b/request/request.d.ts @@ -86,7 +86,7 @@ declare module 'request' { qs?: any; json?: any; multipart?: RequestPart[] | Multipart; - agent?: http.Agent; + agent?: http.Agent | https.Agent; agentOptions?: any; agentClass?: any; forever?: any; From 3a8543ff3d47bdca9f5497f9e4feb06b2ff86d30 Mon Sep 17 00:00:00 2001 From: davidyaozw Date: Fri, 11 Mar 2016 21:46:50 +0800 Subject: [PATCH 3/4] Update request.d.ts import https module to fix ci failure --- request/request.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/request/request.d.ts b/request/request.d.ts index ba07bf4dd..192c3fe69 100644 --- a/request/request.d.ts +++ b/request/request.d.ts @@ -11,6 +11,7 @@ declare module 'request' { import stream = require('stream'); import http = require('http'); + import https = require('https'); import FormData = require('form-data'); import url = require('url'); import fs = require('fs'); From 8a1b587ca51f641d9963e531377609d1be5f5f56 Mon Sep 17 00:00:00 2001 From: davidyaozw Date: Fri, 11 Mar 2016 23:14:43 +0800 Subject: [PATCH 4/4] Update request-tests.ts fix indent --- request/request-tests.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/request/request-tests.ts b/request/request-tests.ts index 3586d0dee..6efeb63c5 100644 --- a/request/request-tests.ts +++ b/request/request-tests.ts @@ -92,7 +92,7 @@ var options: request.Options = { qs: obj, json: value, multipart: value, - agent: new http.Agent(), + agent: new http.Agent(), agentOptions: value, agentClass: value, forever: value, @@ -661,4 +661,4 @@ request( .on('response', function(resp: http.IncomingMessage) { }) .on('data', function(data: Buffer | string) { }) .on('error', function(e: Error) { }) - .on('complete', function(resp: http.IncomingMessage, body?: string | Buffer) { }); \ No newline at end of file + .on('complete', function(resp: http.IncomingMessage, body?: string | Buffer) { });