From 0b49ce3f5800773a15b8520dd44a5bed7c1ac93e Mon Sep 17 00:00:00 2001 From: raphj Date: Tue, 27 Oct 2015 13:30:34 +0100 Subject: [PATCH 1/2] Optional base parameter in the big-integer module --- big-integer/big-integer.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/big-integer/big-integer.d.ts b/big-integer/big-integer.d.ts index 633432e19..9e9127e83 100644 --- a/big-integer/big-integer.d.ts +++ b/big-integer/big-integer.d.ts @@ -214,7 +214,7 @@ interface BigIntegerStatic { /** Parse a Javascript number into a bigInt */ ( number: number ): BigInteger; /** Parse a string into a bigInt */ - ( string: string ): BigInteger; + ( string: string, base?: string | number | BigInteger): BigInteger; /** no-op */ ( bigInt: BigInteger ): BigInteger; } @@ -223,4 +223,4 @@ declare var bigInt: BigIntegerStatic; declare module "big-integer" { export = bigInt; -} \ No newline at end of file +} From 9c256f5bf1e5c0d717fd31f91fa3e72924c95574 Mon Sep 17 00:00:00 2001 From: raphj Date: Tue, 27 Oct 2015 13:31:43 +0100 Subject: [PATCH 2/2] Tests for base argument in big-integer --- big-integer/big-integer-tests.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/big-integer/big-integer-tests.ts b/big-integer/big-integer-tests.ts index 3b9fb8745..92633d287 100644 --- a/big-integer/big-integer-tests.ts +++ b/big-integer/big-integer-tests.ts @@ -4,6 +4,9 @@ var noArgument = bigInt(), numberArgument = bigInt( 93 ), stringArgument = bigInt( "75643564363473453456342378564387956906736546456235345" ), + baseArgumentInt = bigInt( "101010", 2 ), + baseArgumentStr = bigInt( "101010", "2" ), + baseArgumentBi = bigInt( "101010", bigInt( 2 ) ), bigIntArgument = bigInt( noArgument ); // method tests @@ -111,4 +114,4 @@ isNumber = x.toJSNumber(); isString = x.toString(); -isNumber = x.valueOf(); \ No newline at end of file +isNumber = x.valueOf();