From 26c17dce8da4e739784ef3d1c8afae2536f701db Mon Sep 17 00:00:00 2001 From: pspi Date: Mon, 17 Nov 2014 08:26:47 +0200 Subject: [PATCH 1/2] allow method chaining with .on() --- request/request-tests.ts | 7 +++++++ request/request.d.ts | 2 ++ 2 files changed, 9 insertions(+) diff --git a/request/request-tests.ts b/request/request-tests.ts index 506205db8..49a5775fe 100644 --- a/request/request-tests.ts +++ b/request/request-tests.ts @@ -197,3 +197,10 @@ r.post(str); r(options); r.get(options); r.post(options); + +request +.get('http://example.com/example.png') +.on('response', function(response) { + // check response +}) +.pipe(request.put('http://another.com/another.png')); diff --git a/request/request.d.ts b/request/request.d.ts index d8d058d1d..eff35ada6 100644 --- a/request/request.d.ts +++ b/request/request.d.ts @@ -110,6 +110,8 @@ declare module 'request' { oauth(oauth: OAuthOptions): Request; jar(jar: CookieJar): Request; + on(event: string, listener: Function): Request; + write(buffer: Buffer, cb?: Function): boolean; write(str: string, cb?: Function): boolean; write(str: string, encoding: string, cb?: Function): boolean; From ffd35dda9723f86348a35b93a105ebe8968cbe27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Panu=20Pitk=C3=A4m=C3=A4ki?= Date: Mon, 17 Nov 2014 08:53:31 +0200 Subject: [PATCH 2/2] fix travis, any check --- request/request-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/request/request-tests.ts b/request/request-tests.ts index 49a5775fe..64aef2a04 100644 --- a/request/request-tests.ts +++ b/request/request-tests.ts @@ -200,7 +200,7 @@ r.post(options); request .get('http://example.com/example.png') -.on('response', function(response) { +.on('response', function(response: any) { // check response }) .pipe(request.put('http://another.com/another.png'));