From 3930e52ab5991be869c69d9b0d1e720427e5e469 Mon Sep 17 00:00:00 2001 From: pragmat1c Date: Thu, 31 Dec 2015 12:46:25 -0600 Subject: [PATCH 1/2] Update success signature. The success method can return either a json object or a string object in dropzone 4.0.1. Dropzone checks the type and if it's application/json it automatically converts it to json. --- dropzone/dropzone.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dropzone/dropzone.d.ts b/dropzone/dropzone.d.ts index 93f9ca25b..5588ac48d 100644 --- a/dropzone/dropzone.d.ts +++ b/dropzone/dropzone.d.ts @@ -96,7 +96,7 @@ interface DropzoneOptions { sending?(file:DropzoneFile, xhr:XMLHttpRequest, formData:{}):void; sendingmultiple?(files:DropzoneFile[], xhr:XMLHttpRequest, formData:{}):void; - success?(file:DropzoneFile, responseText:string):void; + success?(file: DropzoneFile, response: Object|string): void; successmultiple?(files:DropzoneFile[], responseText:string):void; canceled?(file:DropzoneFile):void; From 0d6fa711d919d4d51ff98ac547f061ee8c2bbbef Mon Sep 17 00:00:00 2001 From: pragmat1c Date: Tue, 5 Jan 2016 11:23:20 -0600 Subject: [PATCH 2/2] Added tests for success signature update --- dropzone/dropzone-tests.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dropzone/dropzone-tests.ts b/dropzone/dropzone-tests.ts index e15d6e038..3893f7c1a 100644 --- a/dropzone/dropzone-tests.ts +++ b/dropzone/dropzone-tests.ts @@ -131,6 +131,13 @@ dropzoneWithOptionsVariations = new Dropzone(".test", { clickable: ["test", document.getElementById("test")] }); +dropzoneWithOptionsVariations = new Dropzone(".test", { + success: (file:DropzoneFile, response:Object) => console.log(file, response) +}); +dropzoneWithOptionsVariations = new Dropzone(".test", { + success: (file:DropzoneFile, response:string) => console.log(file, response) +}); + const dropzone = new Dropzone(".test"); dropzone.enable();