From 80ee73de668a4f773aa6691dc088929df0ed7d55 Mon Sep 17 00:00:00 2001 From: Maciej Kowalski Date: Thu, 23 Jul 2015 19:09:09 +0200 Subject: [PATCH 1/2] fix request.d.ts CookieJar signature --- request/request.d.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/request/request.d.ts b/request/request.d.ts index e16eafadb..e01ba2cc7 100644 --- a/request/request.d.ts +++ b/request/request.d.ts @@ -12,6 +12,7 @@ declare module 'request' { import stream = require('stream'); import http = require('http'); import FormData = require('form-data'); + import url = require('url'); export = RequestAPI; @@ -160,9 +161,9 @@ declare module 'request' { } export interface CookieJar { - add(cookie: Cookie): void; - get(req: Request): Cookie; - cookieString(req: Request): string; + setCookie(cookie: Cookie, uri: string|url.Url, options?: any): void + getCookieString(uri: string|url.Url): string + getCookies(uri: string|url.Url): Cookies[] } export interface CookieValue { From 5cbfd00b618e5089c7ee31a8c2d77e955c7ffed9 Mon Sep 17 00:00:00 2001 From: Maciej Kowalski Date: Thu, 23 Jul 2015 19:09:09 +0200 Subject: [PATCH 2/2] fix request.d.ts CookieJar signature --- request/request-tests.ts | 6 +++--- request/request.d.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/request/request-tests.ts b/request/request-tests.ts index 64aef2a04..9d7cbf3bc 100644 --- a/request/request-tests.ts +++ b/request/request-tests.ts @@ -46,9 +46,9 @@ str = cookie.path; str = cookie.toString(); var jar: request.CookieJar; -jar.add(cookie); -cookie = jar.get(req); -str = jar.cookieString(req); +jar.setCookie(cookie, uri); +str = jar.getCookieString(uri); +var cookies: request.Cookie[] = jar.getCookies(uri); var aws: request.AWSOptions; str = aws.secret; diff --git a/request/request.d.ts b/request/request.d.ts index e01ba2cc7..7b625241c 100644 --- a/request/request.d.ts +++ b/request/request.d.ts @@ -163,7 +163,7 @@ declare module 'request' { export interface CookieJar { setCookie(cookie: Cookie, uri: string|url.Url, options?: any): void getCookieString(uri: string|url.Url): string - getCookies(uri: string|url.Url): Cookies[] + getCookies(uri: string|url.Url): Cookie[] } export interface CookieValue {