From 6a3cee4272ba394009713975184f56fe7bb80f82 Mon Sep 17 00:00:00 2001 From: Vincent Siao Date: Fri, 26 Feb 2016 12:50:00 -0800 Subject: [PATCH] [react-bootstrap] Fix types Found some issues with the current type definitions: - extends `React.Props` with incorrect type `T` (`T` should be component instance type, not component class type) - extends `React.ComponentClass` even if the component is created with `React.createClass` (should extend `ClassiComponentClass`). --- react-bootstrap/react-bootstrap.d.ts | 443 +++++++++++---------------- 1 file changed, 174 insertions(+), 269 deletions(-) diff --git a/react-bootstrap/react-bootstrap.d.ts b/react-bootstrap/react-bootstrap.d.ts index af1cc7338..1c829205c 100644 --- a/react-bootstrap/react-bootstrap.d.ts +++ b/react-bootstrap/react-bootstrap.d.ts @@ -1,6 +1,6 @@ // Type definitions for react-bootstrap // Project: https://github.com/react-bootstrap/react-bootstrap -// Definitions by: Walker Burgin +// Definitions by: Walker Burgin , Vincent Siao // Definitions: https://github.com/borisyankov/DefinitelyTyped /// @@ -12,7 +12,7 @@ declare module "react-bootstrap" { //