From f5b19e8dd70c9f35cd32ca900bf4553f9ce09221 Mon Sep 17 00:00:00 2001 From: John Purcell Date: Wed, 26 Mar 2014 15:07:49 -0400 Subject: [PATCH] Return http.Server from express.listen() --- express/express-tests.ts | 7 +++++++ express/express.d.ts | 10 +++++----- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/express/express-tests.ts b/express/express-tests.ts index 3efdf19a6..57d1d638c 100644 --- a/express/express-tests.ts +++ b/express/express-tests.ts @@ -1489,3 +1489,10 @@ function test_middleware() { app.use(express.static('public')); app.use(router.middleware); } + +//////////////////// + +// make sure server can be shut down +var testShutdownServer = app.listen(0); +console.log('listening on port ' + testShutdownServer.address().port); +testShutdownServer.close(); diff --git a/express/express.d.ts b/express/express.d.ts index 243aa41d4..7dd170629 100644 --- a/express/express.d.ts +++ b/express/express.d.ts @@ -1112,15 +1112,15 @@ declare module "express" { * http.createServer(app).listen(80); * https.createServer({ ... }, app).listen(443); */ - listen(port: number, hostname: string, backlog: number, callback?: Function): void; + listen(port: number, hostname: string, backlog: number, callback?: Function): http.Server; - listen(port: number, hostname: string, callback?: Function): void; + listen(port: number, hostname: string, callback?: Function): http.Server; - listen(port: number, callback?: Function): void; + listen(port: number, callback?: Function): http.Server; - listen(path: string, callback?: Function): void; + listen(path: string, callback?: Function): http.Server; - listen(handle: any, listeningListener?: Function): void; + listen(handle: any, listeningListener?: Function): http.Server; route: IRoute;