From ff9365dc084d64c948e9c4276291ba0a25c0d006 Mon Sep 17 00:00:00 2001 From: Steven Date: Wed, 9 Jul 2014 16:08:20 -0700 Subject: [PATCH 1/3] Fix interface for getIdxById in SlickGrid It is clear by the name of this method that it takes an id (string) and returns and index (number). --- slickgrid/SlickGrid.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slickgrid/SlickGrid.d.ts b/slickgrid/SlickGrid.d.ts index 9e66b9647..4c75fbf1f 100644 --- a/slickgrid/SlickGrid.d.ts +++ b/slickgrid/SlickGrid.d.ts @@ -1539,7 +1539,7 @@ declare module Slick { */ public expandGroup(...varArgs: string[]): void; public getGroups(): Group[]; - public getIdxById(): string; + public getIdxById(string): number; public getRowById(): T; public getItemById(id: any): T; public getItemByIdx(): T; From ea9eedcc07d475b1a2adbe8bc1477812d9fa7248 Mon Sep 17 00:00:00 2001 From: Steven Date: Wed, 9 Jul 2014 16:18:23 -0700 Subject: [PATCH 2/3] Added test for getIdxById --- slickgrid/SlickGrid-tests.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/slickgrid/SlickGrid-tests.ts b/slickgrid/SlickGrid-tests.ts index 1b41d1a0b..50db88b52 100644 --- a/slickgrid/SlickGrid-tests.ts +++ b/slickgrid/SlickGrid-tests.ts @@ -196,3 +196,7 @@ grid.setCellCssStyles("test", { } }); +// Begin DataView tests +var dataView = new Slick.Data.DataView(); +var gridWithDataView = new Slick.Grid('#grid2', dataView, columns, options); +dataView.getIdxById('foo') + 5; From e448b8cbf60872f5876179f30c9bb004d8465a3c Mon Sep 17 00:00:00 2001 From: Steven Date: Wed, 9 Jul 2014 16:31:41 -0700 Subject: [PATCH 3/3] Changed to explicit ID parameter --- slickgrid/SlickGrid.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slickgrid/SlickGrid.d.ts b/slickgrid/SlickGrid.d.ts index 4c75fbf1f..90aa9cf13 100644 --- a/slickgrid/SlickGrid.d.ts +++ b/slickgrid/SlickGrid.d.ts @@ -1539,7 +1539,7 @@ declare module Slick { */ public expandGroup(...varArgs: string[]): void; public getGroups(): Group[]; - public getIdxById(string): number; + public getIdxById(id: string): number; public getRowById(): T; public getItemById(id: any): T; public getItemByIdx(): T;