From fe5fba39079dfdeeeec613d7b55969409218a60d Mon Sep 17 00:00:00 2001 From: Kerrick Long Date: Tue, 19 Jul 2011 22:03:11 -0500 Subject: [PATCH] various quick fixes and cleanups prior to release --- README.markdown | 26 +------------------------- TODO.markdown | 7 ------- fancy-settings/manifest.js | 4 ++-- js/common.js | 8 +++----- manifest.json | 2 +- 5 files changed, 7 insertions(+), 40 deletions(-) delete mode 100644 TODO.markdown diff --git a/README.markdown b/README.markdown index d6408b9..28e8a67 100644 --- a/README.markdown +++ b/README.markdown @@ -1,25 +1 @@ -## Mostly Harmless ## - -This is an upcoming reddit extension for Google Chrome. - -### Roadmap - -1. Share -- get it working or not? - -2. Submission dialog for pages that haven't been submitted to reddit. - -3. Submission dialog for pages that have been submitted to reddit, provided you're not reposting the same link to a subreddit. - -4. Depending on user feedback, I might add special support for reposts. The extension could append a URL query string to it so it still goes through. - -6. **Privacy** - when [Fancy Settings](https://github.com/frankkohlhepp/fancy-settings) supports textareas, I'll add the capability to exclude domains and regular expression matches from being looked up. - -7. I hope to open source this and get it officially endorsed by reddit in the same way Socialite, RedditAddict, and Reddit Companion are. - -## Known Issues ## - -* After clicking a vote icon, hide, or report, the state may not *appear* to change unless you move your mouse over what you just clicked. However, often you move your mouse to get away from the element, so you won't usually see this. This is a [known bug in Google Chrome](http://code.google.com/p/chromium/issues/detail?id=77246). - -* Share doesn't work yet. - -* There is no submission form yet. \ No newline at end of file +## [Please view the Mostly Harmless website for information about this Google Chrome extension for awesome redditors](http://kerrick.github.com/Mostly-Harmless)! \ No newline at end of file diff --git a/TODO.markdown b/TODO.markdown deleted file mode 100644 index 9d420c3..0000000 --- a/TODO.markdown +++ /dev/null @@ -1,7 +0,0 @@ -// IDEAS -How about parsing imgur to look for direct AND imgur links? -User preference to sort by freshness, score, comment count! -Excluded sites - When on ignored pages, badge can be black with a white X - Clicking the badge can take the user to the options page about excluded sites -Voting and score on the right? I know, blasphemy, but it'd make it less mouse-travel to vote. \ No newline at end of file diff --git a/fancy-settings/manifest.js b/fancy-settings/manifest.js index fba6ee8..ceddad3 100755 --- a/fancy-settings/manifest.js +++ b/fancy-settings/manifest.js @@ -109,8 +109,8 @@ this.manifest = { "name": "mailDisplayTime", "type": "slider", "label": "", - "max": 20, - "min": 5, + "max": 60, + "min": 10, "step": 1, "display": true, "displayModifier": function (value) { diff --git a/js/common.js b/js/common.js index 042c439..01b33c7 100644 --- a/js/common.js +++ b/js/common.js @@ -8,10 +8,10 @@ settings = new Store('settings', { 'shamelessPlug': false, 'waitForClick': false, 'checkMail': true, - 'mailInterval': 1, - 'mailDisplayTime': 10, + 'mailInterval': 5, + 'mailDisplayTime': 30, 'mailSound': false, - 'excludedDomains': 'secure.ingdirect.com\nchaseonline.chase.com\nonline.wellsfargo.com', + 'excludedDomains': 'secure.ingdirect.com\nchaseonline.chase.com\nonline.wellsfargo.com\nmail.google.com\ndocs.google.com', 'excludedRegex': 'chrome://.*\nchrome-extension://.*\nview-source://.*\nftp://.*\nhttps?://www\\.google\\.com/search.*\nhttps?://search\\.yahoo\\.com/search.*\nhttps?://www\\.bing\\.com/search.*\nhttps?://www\\.reddit\\.com/(?:r/(?:\\w|\\+)+/?)?(?:$|\\?count)' }); cache = new Store('cache'); @@ -744,8 +744,6 @@ RedditAPI.prototype.submitLink = function (e, tabId) { var url, title, subreddit, status, submitButton, formData; function afterSubmission (response) { - console.log(response); - if (response.jquery[22]) { status.innerHTML = response.jquery[22][3][0]; } else { diff --git a/manifest.json b/manifest.json index 3e0eb36..bc2645e 100644 --- a/manifest.json +++ b/manifest.json @@ -1,7 +1,7 @@ { "name": "Mostly Harmless", "version": "1.0.0", - "description": "Easily see how many times URL has been posted to reddit, join the discussion, submit or repost it, and more!", + "description": "Easily see how many times a URL has been posted to reddit, join the discussion, and vote on, save, hide, and report the posts. If the page has not been submitted, you can post the URL, there are plenty of options for customization and privacy!", "browser_action": { "default_icon": "pix/alien.png", "popup": "html/popup.html"