From 6b7cb74e5d5623fbd41b172db4fb719bf6ba2f8e Mon Sep 17 00:00:00 2001 From: Adrian Cowan Date: Mon, 30 Jan 2023 23:36:42 +1100 Subject: [PATCH] website: Fix regression that broke the ability to review unchanged rankings. This was caused by the init effect in Task.tsx running _after_ the task submits it's default reply validity as part of it's init effect. Clearly we need to refactor the way Task.tsx works. --- website/src/components/Tasks/Task/Task.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/src/components/Tasks/Task/Task.tsx b/website/src/components/Tasks/Task/Task.tsx index f251cdd0..c10ab597 100644 --- a/website/src/components/Tasks/Task/Task.tsx +++ b/website/src/components/Tasks/Task/Task.tsx @@ -74,7 +74,7 @@ export const Task = () => { ): TaskStatus => { switch (event.action) { case "NEW_TASK": - return { mode: "EDIT", replyValidity: "INVALID" }; + return status.mode !== "EDIT" ? { mode: "EDIT", replyValidity: "INVALID" } : status; case "UPDATE_VALIDITY": return status.mode === "EDIT" ? { mode: "EDIT", replyValidity: event.replyValidity } : status; case "ACCEPT_DEFAULT":