wassname/catalyst
1
0
Fork 0
mirror of https://github.com/wassname/catalyst.git synced 2026-09-12 12:12:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

ENH: Improve error message on bad return.

Browse Source
This commit is contained in:
Scott Sanderson
2017-06-07 17:07:19 -04:00
parent 709735de51
commit 09cc54e08a
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_labelarray.py
+1 -1
View File
@@ -153,7 +153,7 @@ class LabelArrayTestCase(ZiplineTestCase):
lambda s: object(), lambda s: object(),
] ]
) )
def test_map_requires_f_to_return_a_string(self, f): def test_map_requires_f_to_return_a_string_or_none(self, f):
la = LabelArray(self.strs, missing_value=None) la = LabelArray(self.strs, missing_value=None)
with self.assertRaises(TypeError): with self.assertRaises(TypeError):
zipline/lib/labelarray.py
+6 -2
View File
@@ -591,8 +591,12 @@ class LabelArray(ndarray):
if not isinstance(ret, otypes): if not isinstance(ret, otypes):
raise TypeError( raise TypeError(
"Expected f() to return a string. Got %s." % ( "LabelArray.map expected function {f} to return a string"
type(ret).__name__ " or None, but got {type} instead.\n"
"Value was {value}.".format(
f=f.__name__,
type=type(ret).__name__,
value=ret,
) )
) )