From 50dc322230ec345584ce5c5ecbdf67cb92488619 Mon Sep 17 00:00:00 2001 From: Frederic Fortier Date: Fri, 12 Jan 2018 19:53:26 -0500 Subject: [PATCH] BLD: minor adjustments and updated release notes --- catalyst/examples/mean_reversion_simple.py | 1 + catalyst/exchange/ccxt/ccxt_exchange.py | 5 +++++ docs/source/releases.rst | 1 + 3 files changed, 7 insertions(+) diff --git a/catalyst/examples/mean_reversion_simple.py b/catalyst/examples/mean_reversion_simple.py index 5a55b83c..084411d9 100644 --- a/catalyst/examples/mean_reversion_simple.py +++ b/catalyst/examples/mean_reversion_simple.py @@ -259,6 +259,7 @@ if __name__ == '__main__': live_graph=False, simulate_orders=False, stats_output=None, + # auth_aliases=dict(poloniex='auth2') ) else: diff --git a/catalyst/exchange/ccxt/ccxt_exchange.py b/catalyst/exchange/ccxt/ccxt_exchange.py index 19b8d233..164d5476 100644 --- a/catalyst/exchange/ccxt/ccxt_exchange.py +++ b/catalyst/exchange/ccxt/ccxt_exchange.py @@ -1011,6 +1011,11 @@ class CCXT(Exchange): return result def get_trades(self, asset, my_trades=True, start_dt=None, limit=None): + if not my_trades: + raise NotImplemented( + 'get_trades only supports "my trades"' + ) + # TODO: is it possible to sort this? Limit is useless otherwise. ccxt_symbol = self.get_symbol(asset) try: diff --git a/docs/source/releases.rst b/docs/source/releases.rst index bdeeca00..78d17ca8 100644 --- a/docs/source/releases.rst +++ b/docs/source/releases.rst @@ -11,6 +11,7 @@ Bug Fixes - Improved order execution for exchanges supporting trade lists (:issue:`151`) - Fixed an issue where requesting history of multiple assets repeats values - Raising an error for order amounts smaller than exchange lots +- Handling multiple req errors with tickers more gracefully (:issue:`160`) Version 0.4.4 ^^^^^^^^^^^^^