wassname/catalyst
1
0
Fork 0
mirror of https://github.com/wassname/catalyst.git synced 2026-07-25 13:10:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

PERF: Reimplemented remember_last with a weak_lru_cache

Browse Source 
which won't leak instances whose methods have been decorated

(specifically DataPortal instances)

MAINT: Not using functools32 anymore
This commit is contained in:
Richard Frank
2016-04-12 19:33:21 -04:00
parent 32a400a9fb
commit 5254b273b2
5 changed files with 279 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_memoize.py
+62
View File
@@ -1,6 +1,8 @@
"""
Tests for zipline.utils.memoize.
"""
from collections import defaultdict
import gc
from unittest import TestCase
from zipline.utils.memoize import remember_last
@@ -32,3 +34,63 @@ class TestRememberLast(TestCase):
# Calling the old value should still increment the counter.
self.assertEqual((func(1), call_count[0]), (1, 3))
self.assertEqual((func(1), call_count[0]), (1, 3))
def test_remember_last_method(self):
call_count = defaultdict(int)
class clz(object):
@remember_last
def func(self, x):
call_count[(self, x)] += 1
return x
inst1 = clz()
self.assertEqual((inst1.func(1), call_count), (1, {(inst1, 1): 1}))
# Calling again with the same argument should just re-use the old
# value, which means func shouldn't get called again.
self.assertEqual((inst1.func(1), call_count), (1, {(inst1, 1): 1}))
# Calling with a new value should increment the counter.
self.assertEqual((inst1.func(2), call_count), (2, {(inst1, 1): 1,
(inst1, 2): 1}))
self.assertEqual((inst1.func(2), call_count), (2, {(inst1, 1): 1,
(inst1, 2): 1}))
# Calling the old value should still increment the counter.
self.assertEqual((inst1.func(1), call_count), (1, {(inst1, 1): 2,
(inst1, 2): 1}))
self.assertEqual((inst1.func(1), call_count), (1, {(inst1, 1): 2,
(inst1, 2): 1}))
inst2 = clz()
self.assertEqual((inst2.func(1), call_count),
(1, {(inst1, 1): 2, (inst1, 2): 1,
(inst2, 1): 1}))
self.assertEqual((inst2.func(1), call_count),
(1, {(inst1, 1): 2, (inst1, 2): 1,
(inst2, 1): 1}))
self.assertEqual((inst2.func(2), call_count),
(2, {(inst1, 1): 2, (inst1, 2): 1,
(inst2, 1): 1, (inst2, 2): 1}))
self.assertEqual((inst2.func(2), call_count),
(2, {(inst1, 1): 2, (inst1, 2): 1,
(inst2, 1): 1, (inst2, 2): 1}))
self.assertEqual((inst2.func(1), call_count),
(1, {(inst1, 1): 2, (inst1, 2): 1,
(inst2, 1): 2, (inst2, 2): 1}))
self.assertEqual((inst2.func(1), call_count),
(1, {(inst1, 1): 2, (inst1, 2): 1,
(inst2, 1): 2, (inst2, 2): 1}))
# Remove the above references to the instances and ensure that
# remember_last has not made its own.
del inst1, inst2
call_count.clear()
while gc.collect():
pass
self.assertFalse([inst for inst in gc.get_objects()
if type(inst) == clz])