wassname/catalyst
1
0
Fork 0
mirror of https://github.com/wassname/catalyst.git synced 2026-08-14 12:10:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

MAINT: Check dates before computing factor_matrix.

Browse Source 
In SimpleFFCEngine.factor_matrix barf with a useful error if end_date <=
start_date.
This commit is contained in:
Scott Sanderson
2015-08-03 12:06:24 -04:00
parent 5da03d2df5
commit 7bb20eb297
2 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/modelling/test_engine.py
+10
View File
@@ -85,6 +85,16 @@ class ConstantInputTestCase(TestCase):
)
self.asset_finder = AssetFinder(self.asset_info)
def test_bad_dates(self):
loader = self.loader
engine = SimpleFFCEngine(loader, self.dates, self.asset_finder)
msg = "start_date must be before end_date .*"
with self.assertRaisesRegexp(ValueError, msg):
engine.factor_matrix({}, self.dates[2], self.dates[1])
with self.assertRaisesRegexp(ValueError, msg):
engine.factor_matrix({}, self.dates[2], self.dates[2])
def test_single_factor(self):
loader = self.loader
engine = SimpleFFCEngine(loader, self.dates, self.asset_finder)