wassname/catalyst
1
0
Fork 0
mirror of https://github.com/wassname/catalyst.git synced 2026-07-09 12:16:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

MAINT: Limit perspective offset.

Browse Source 
Limit the perspective offset to 1. There is a possibility that if a
consumer of the AdjustedArrayWindow does not fetch adjustments between
the end of the data window and the vantage points beyond the end of the
window.

Until that case has a solution, e.g. having the consumer of the
AdjustedArrayWindow include the perspective offset when calculating the
query for adjustments, limit the offsets to 1.
This commit is contained in:
Eddie Hebert
2016-10-17 15:08:11 -04:00
parent 62f24dcad7
commit 7d8768e2e4
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/pipeline/test_adjusted_array.py
+3 -3
View File
@@ -215,7 +215,7 @@ def _gen_multiplicative_adjustment_cases(dtype):
adjustments,
buffer_as_of,
nrows,
perspective_offsets=(0, 1, 2, 1000),
perspective_offsets=(0, 1),
)
@@ -318,7 +318,7 @@ def _gen_overwrite_adjustment_cases(dtype):
adjustments,
buffer_as_of,
nrows=6,
perspective_offsets=(0, 1, 2, 1000),
perspective_offsets=(0, 1),
)
@@ -421,7 +421,7 @@ def _gen_overwrite_1d_array_adjustment_case(dtype):
adjustments,
buffer_as_of,
nrows=6,
perspective_offsets=(0, 1, 2, 1000),
perspective_offsets=(0, 1),
)