From 82273e296f0863e6ff10dff4e7aa6cf016ae4b3e Mon Sep 17 00:00:00 2001 From: jkleint Date: Fri, 23 Sep 2016 15:55:55 -0700 Subject: [PATCH] Propagate exceptions in loader to prevent variable reference before use `data.loader.ensure_benchmark_data()` was trying to use data after an exception was raised loading it. The code was logging and swallowing exceptions; this re-raises. --- zipline/data/loader.py | 1 + 1 file changed, 1 insertion(+) diff --git a/zipline/data/loader.py b/zipline/data/loader.py index 91fa16d4..02519272 100644 --- a/zipline/data/loader.py +++ b/zipline/data/loader.py @@ -249,6 +249,7 @@ def ensure_benchmark_data(symbol, first_date, last_date, now, trading_day): data.to_csv(path) except (OSError, IOError, HTTPError): logger.exception('failed to cache the new benchmark returns') + raise if not has_data_for_dates(data, first_date, last_date): logger.warn("Still don't have expected data after redownload!") return data