From 5888cf1657275b9001beabe93da00257eafbee12 Mon Sep 17 00:00:00 2001
From: ChrisPappalardo <cpappala@yahoo.com>
Date: Thu, 2 Jun 2016 18:12:36 -0700
Subject: [PATCH 1/3] ENH: add true range technical factor

---
 tests/pipeline/test_technical.py      | 18 ++++++++++++++++++
 zipline/pipeline/factors/__init__.py  |  2 ++
 zipline/pipeline/factors/technical.py | 26 ++++++++++++++++++++++++++
 3 files changed, 46 insertions(+)

diff --git a/tests/pipeline/test_technical.py b/tests/pipeline/test_technical.py
index f63d9b8c..4b910a81 100644
--- a/tests/pipeline/test_technical.py
+++ b/tests/pipeline/test_technical.py
@@ -18,6 +18,7 @@ from zipline.pipeline.factors import (
     IchimokuKinkoHyo,
     LinearWeightedMovingAverage,
     RateOfChangePercentage,
+    TrueRange,
 )
 from zipline.testing import ExplodingObject, parameter_space
 from zipline.testing.fixtures import WithAssetFinder, ZiplineTestCase
@@ -413,3 +414,20 @@ class TestLinearWeightedMovingAverage(ZiplineTestCase):
 
         wma2.compute(today, assets, out, data)
         assert_equal(out, np.array([30.,  31.,  32.,  33.,  34.]))
+
+
+class TestTrueRange(WithTechnicalFactor, ZiplineTestCase):
+
+    def test_tr_basic(self):
+        tr = TrueRange()
+
+        today = pd.Timestamp('2014')
+        assets = np.arange(3, dtype=np.int64)
+        out = np.empty(3, dtype=np.float64)
+
+        highs = np.full((2, 3), 3)
+        lows = np.full((2, 3), 2)
+        closes = np.full((2, 3), 1)
+
+        tr.compute(today, assets, out, highs, lows, closes)
+        assert_equal(out, np.full((3,), 2))
diff --git a/zipline/pipeline/factors/__init__.py b/zipline/pipeline/factors/__init__.py
index 0b505813..0155cab6 100644
--- a/zipline/pipeline/factors/__init__.py
+++ b/zipline/pipeline/factors/__init__.py
@@ -29,6 +29,7 @@ from .technical import (
     Returns,
     RSI,
     SimpleMovingAverage,
+    TrueRange,
     VWAP,
     WeightedAverageValue,
 )
@@ -58,6 +59,7 @@ __all__ = [
     'RollingSpearmanOfReturns',
     'RSI',
     'SimpleMovingAverage',
+    'TrueRange',
     'VWAP',
     'WeightedAverageValue',
 ]
diff --git a/zipline/pipeline/factors/technical.py b/zipline/pipeline/factors/technical.py
index 42e1736d..b6e10d24 100644
--- a/zipline/pipeline/factors/technical.py
+++ b/zipline/pipeline/factors/technical.py
@@ -11,6 +11,7 @@ from numpy import (
     average,
     clip,
     diff,
+    dstack,
     exp,
     fmax,
     full,
@@ -642,3 +643,28 @@ class RateOfChangePercentage(CustomFactor):
                  global_dict={},
                  out=out,
                  )
+
+
+class TrueRange(CustomFactor):
+    """
+    True Range
+
+    A technical indicator originally developed by J. Welles Wilder, Jr.
+    Indicates the true degree of daily price change in an underlying.
+    """
+
+    inputs = (USEquityPricing.high, USEquityPricing.low, USEquityPricing.close, )
+    window_length = 2
+
+    def compute(self, today, assets, out, highs, lows, closes):
+        high_to_low = highs[1:] - lows[1:]
+        high_to_prev_close = abs(highs[1:] - closes[:-1])
+        low_to_prev_close = abs(lows[1:] - closes[:-1])
+        out[:] = nanmax(
+            dstack((
+                high_to_low,
+                high_to_prev_close,
+                low_to_prev_close,
+            )),
+            2
+        )

From 072ada812a875a0c78fedd6fe17877936ef35fe3 Mon Sep 17 00:00:00 2001
From: ChrisPappalardo <cpappala@yahoo.com>
Date: Thu, 2 Jun 2016 19:50:05 -0700
Subject: [PATCH 2/3] STY: fixed flake8 failing test

---
 zipline/pipeline/factors/technical.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/zipline/pipeline/factors/technical.py b/zipline/pipeline/factors/technical.py
index b6e10d24..0d03e9c7 100644
--- a/zipline/pipeline/factors/technical.py
+++ b/zipline/pipeline/factors/technical.py
@@ -653,7 +653,8 @@ class TrueRange(CustomFactor):
     Indicates the true degree of daily price change in an underlying.
     """
 
-    inputs = (USEquityPricing.high, USEquityPricing.low, USEquityPricing.close, )
+    inputs = (USEquityPricing.high, USEquityPricing.low,
+              USEquityPricing.close, )
     window_length = 2
 
     def compute(self, today, assets, out, highs, lows, closes):

From 25474cf475e438cae022dc1cf6b20e0a012e85a0 Mon Sep 17 00:00:00 2001
From: Joe Jevnik <joe@quantopian.com>
Date: Mon, 25 Jul 2016 12:36:22 -0400
Subject: [PATCH 3/3] DOC: add default inputs and window length to TrueRange

---
 zipline/pipeline/factors/technical.py | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/zipline/pipeline/factors/technical.py b/zipline/pipeline/factors/technical.py
index 0d03e9c7..23a2a7d8 100644
--- a/zipline/pipeline/factors/technical.py
+++ b/zipline/pipeline/factors/technical.py
@@ -651,10 +651,17 @@ class TrueRange(CustomFactor):
 
     A technical indicator originally developed by J. Welles Wilder, Jr.
     Indicates the true degree of daily price change in an underlying.
-    """
 
-    inputs = (USEquityPricing.high, USEquityPricing.low,
-              USEquityPricing.close, )
+    **Default Inputs:** :data:`zipline.pipeline.data.USEquityPricing.high`
+                        :data:`zipline.pipeline.data.USEquityPricing.low`
+                        :data:`zipline.pipeline.data.USEquityPricing.close`
+    **Default Window Length:** 2
+    """
+    inputs = (
+        USEquityPricing.high,
+        USEquityPricing.low,
+        USEquityPricing.close,
+    )
     window_length = 2
 
     def compute(self, today, assets, out, highs, lows, closes):