From a192ba01a2b1d58e97b0edb3e86461dfb9a2031b Mon Sep 17 00:00:00 2001 From: Eddie Hebert Date: Fri, 1 Nov 2013 15:28:35 -0400 Subject: [PATCH] STY: Used named args in hardcoded test objects. Instead of unrolling a dictionary, use named args. --- tests/finance/test_slippage.py | 9 ++++----- tests/test_perf_tracking.py | 34 ++++++++++++++++------------------ 2 files changed, 20 insertions(+), 23 deletions(-) diff --git a/tests/finance/test_slippage.py b/tests/finance/test_slippage.py index d935a4e7..3569c213 100644 --- a/tests/finance/test_slippage.py +++ b/tests/finance/test_slippage.py @@ -54,11 +54,10 @@ class SlippageTestCase(TestCase): slippage_model = VolumeShareSlippage() open_orders = [ - Order(**{ - 'dt': datetime.datetime(2006, 1, 5, 14, 30, tzinfo=pytz.utc), - 'amount': 100, - 'filled': 0, - 'sid': 133}) + Order(dt=datetime.datetime(2006, 1, 5, 14, 30, tzinfo=pytz.utc), + amount=100, + filled=0, + sid=133) ] orders_txns = list(slippage_model.simulate( diff --git a/tests/test_perf_tracking.py b/tests/test_perf_tracking.py index 35ddd468..ad86e00a 100644 --- a/tests/test_perf_tracking.py +++ b/tests/test_perf_tracking.py @@ -1166,21 +1166,21 @@ class TestPerformanceTracker(unittest.TestCase): # create a transaction for all but # first trade in each sid, to simulate None transaction if event.dt != no_txn_dt: - order = Order(**{ - 'sid': event.sid, - 'amount': -25, - 'dt': event.dt - }) + order = Order( + sid=event.sid, + amount=-25, + dt=event.dt + ) yield order yield event - txn = Transaction(**{ - 'sid': event.sid, - 'amount': -25, - 'dt': event.dt, - 'price': 10.0, - 'commission': 0.50, - 'order_id': order.id - }) + txn = Transaction( + sid=event.sid, + amount=-25, + dt=event.dt, + price=10.0, + commission=0.50, + order_id=order.id + ) yield txn else: yield event @@ -1201,11 +1201,9 @@ class TestPerformanceTracker(unittest.TestCase): tracker = perf.PerformanceTracker(sim_params) foo_event_1 = factory.create_trade('foo', 10.0, 20, start_dt) - order_event_1 = Order(**{ - 'sid': foo_event_1.sid, - 'amount': -25, - 'dt': foo_event_1.dt - }) + order_event_1 = Order(sid=foo_event_1.sid, + amount=-25, + dt=foo_event_1.dt) bar_event_1 = factory.create_trade('bar', 100.0, 200, start_dt) txn_event_1 = Transaction(sid=foo_event_1.sid, amount=-25,