mirror of
https://github.com/wassname/catalyst.git
synced 2026-07-26 13:18:31 +08:00
MAINT: modify next_date_frame and prev_date_frame to mirror previous_value.
MAINT: clean up and improve docs. BUG: fix imports. MAINT: refactor test. MAINT: change class name. MAINT: remove error since won't be reached. TST: improve and expand tests. MAINT: change class name. MAINT: change class name. MAINT: extract string constants and remove error that won't be reached. STY: fix line length. MAINT: undo name change.
This commit is contained in:
@@ -462,50 +462,3 @@ class BlazeCashBuybackAuthLoaderNotInteractiveTestCase(
|
||||
self,
|
||||
).loader_args(dates)
|
||||
return swap_resources_into_scope(bound_expr, {})
|
||||
|
||||
dtx = pd.date_range('2014-01-01', '2014-01-10')
|
||||
|
||||
|
||||
class BuybackAuthLoaderInferTimestampTestCase(TestCase):
|
||||
# 'fields' needs to match expected fields for the given loader to
|
||||
# satisfy column check in constructor.
|
||||
@parameterized.expand([[CashBuybackAuthorizationsLoader,
|
||||
{BUYBACK_ANNOUNCEMENT_FIELD_NAME: dtx,
|
||||
CASH_FIELD_NAME: [0] * 10}],
|
||||
[ShareBuybackAuthorizationsLoader,
|
||||
{BUYBACK_ANNOUNCEMENT_FIELD_NAME: dtx,
|
||||
SHARE_COUNT_FIELD_NAME: [0] * 10}]])
|
||||
def test_infer_timestamp(self, loader, fields):
|
||||
events_by_sid = {
|
||||
# No timestamp column - should index by first given date
|
||||
0: pd.DataFrame(fields),
|
||||
# timestamp column exists - should index by it
|
||||
1: pd.DataFrame(dict(fields, **{TS_FIELD_NAME: dtx}))
|
||||
}
|
||||
loader = loader(
|
||||
dtx,
|
||||
events_by_sid,
|
||||
infer_timestamps=True,
|
||||
)
|
||||
self.assertEqual(
|
||||
loader.events_by_sid.keys(),
|
||||
events_by_sid.keys(),
|
||||
)
|
||||
|
||||
# Check that index by first given date has been added
|
||||
assert_series_equal(
|
||||
loader.events_by_sid[0][BUYBACK_ANNOUNCEMENT_FIELD_NAME],
|
||||
pd.Series(index=[dtx[0]] * 10,
|
||||
data=dtx,
|
||||
name=BUYBACK_ANNOUNCEMENT_FIELD_NAME),
|
||||
)
|
||||
|
||||
# Check that timestamp column was turned into index
|
||||
modified_events_by_sid_date_col = pd.Series(data=np.array(
|
||||
events_by_sid[1][BUYBACK_ANNOUNCEMENT_FIELD_NAME]),
|
||||
index=events_by_sid[1][TS_FIELD_NAME],
|
||||
name=BUYBACK_ANNOUNCEMENT_FIELD_NAME)
|
||||
assert_series_equal(
|
||||
loader.events_by_sid[1][BUYBACK_ANNOUNCEMENT_FIELD_NAME],
|
||||
modified_events_by_sid_date_col,
|
||||
)
|
||||
|
||||
@@ -365,39 +365,3 @@ class BlazeEarningsCalendarLoaderNotInteractiveTestCase(
|
||||
self,
|
||||
).loader_args(dates)
|
||||
return swap_resources_into_scope(bound_expr, {})
|
||||
|
||||
|
||||
class EarningsCalendarLoaderInferTimestampTestCase(TestCase):
|
||||
def test_infer_timestamp(self):
|
||||
dtx = pd.date_range('2014-01-01', '2014-01-10')
|
||||
announcement_dates = {
|
||||
0: pd.DataFrame({ANNOUNCEMENT_FIELD_NAME: dtx}),
|
||||
1: pd.DataFrame(
|
||||
{TS_FIELD_NAME: dtx, ANNOUNCEMENT_FIELD_NAME: dtx}
|
||||
),
|
||||
}
|
||||
loader = EarningsCalendarLoader(
|
||||
dtx,
|
||||
announcement_dates,
|
||||
infer_timestamps=True,
|
||||
)
|
||||
self.assertEqual(
|
||||
loader.events_by_sid.keys(),
|
||||
announcement_dates.keys(),
|
||||
)
|
||||
assert_series_equal(
|
||||
loader.events_by_sid[0].loc[:, ANNOUNCEMENT_FIELD_NAME],
|
||||
pd.Series(index=[dtx[0]] * 10,
|
||||
data=dtx,
|
||||
name=ANNOUNCEMENT_FIELD_NAME),
|
||||
)
|
||||
assert_series_equal(
|
||||
loader.events_by_sid[1][ANNOUNCEMENT_FIELD_NAME],
|
||||
pd.Series(
|
||||
index=announcement_dates[1][TS_FIELD_NAME],
|
||||
data=np.array(
|
||||
announcement_dates[1][ANNOUNCEMENT_FIELD_NAME]
|
||||
),
|
||||
name=ANNOUNCEMENT_FIELD_NAME
|
||||
)
|
||||
)
|
||||
|
||||
@@ -1 +1,191 @@
|
||||
__author__ = 'mtydykov'
|
||||
"""
|
||||
Tests for setting up an EventsLoader and a BlazeEventsLoader.
|
||||
"""
|
||||
from nose_parameterized import parameterized
|
||||
|
||||
import blaze as bz
|
||||
import pandas as pd
|
||||
from pandas.util.testing import assert_series_equal, TestCase, assertRaises
|
||||
|
||||
from zipline.pipeline.data import DataSet, Column
|
||||
from zipline.pipeline.loaders.blaze.events import BlazeEventsLoader
|
||||
from zipline.pipeline.loaders.events import (
|
||||
BAD_DATA_FORMAT_ERROR,
|
||||
DF_NO_TS_NOT_INFER_TS_ERROR,
|
||||
DTINDEX_NOT_INFER_TS_ERROR,
|
||||
EventsLoader,
|
||||
SERIES_NO_DTINDEX_ERROR,
|
||||
SID_FIELD_NAME,
|
||||
TS_FIELD_NAME,
|
||||
WRONG_COLS_ERROR,
|
||||
)
|
||||
from zipline.utils.memoize import lazyval
|
||||
from zipline.utils.numpy_utils import datetime64ns_dtype
|
||||
|
||||
ABSTRACT_METHODS_ERROR = 'abstract methods concrete_loader'
|
||||
|
||||
DAYS_SINCE_PREV = 'days_since_prev'
|
||||
|
||||
PREVIOUS_ANNOUNCEMENT = 'previous_announcement'
|
||||
|
||||
ANNOUNCEMENT_FIELD_NAME = 'announcement_date'
|
||||
|
||||
|
||||
class EventDataSet(DataSet):
|
||||
previous_announcement = Column(datetime64ns_dtype)
|
||||
|
||||
|
||||
class EventDataSetLoader(EventsLoader):
|
||||
|
||||
def __init__(self,
|
||||
all_dates,
|
||||
events_by_sid,
|
||||
infer_timestamps=False,
|
||||
dataset=EventDataSet):
|
||||
super(EventDataSetLoader, self).__init__(
|
||||
all_dates,
|
||||
events_by_sid,
|
||||
infer_timestamps=infer_timestamps,
|
||||
dataset=dataset,
|
||||
)
|
||||
|
||||
@property
|
||||
def expected_cols(self):
|
||||
return frozenset([ANNOUNCEMENT_FIELD_NAME])
|
||||
|
||||
@lazyval
|
||||
def previous_announcement_loader(self):
|
||||
return self._previous_event_date_loader(
|
||||
self.dataset.previous_announcement,
|
||||
ANNOUNCEMENT_FIELD_NAME,
|
||||
)
|
||||
|
||||
@lazyval
|
||||
def next_announcement_loader(self):
|
||||
return self._previous_event_date_loader(
|
||||
self.dataset.previous_announcement,
|
||||
ANNOUNCEMENT_FIELD_NAME,
|
||||
)
|
||||
|
||||
|
||||
class EventDataSetLoaderNoExpectedCols(EventsLoader):
|
||||
|
||||
def __init__(self,
|
||||
all_dates,
|
||||
events_by_sid,
|
||||
infer_timestamps=False,
|
||||
dataset=EventDataSet):
|
||||
super(EventDataSetLoaderNoExpectedCols, self).__init__(
|
||||
all_dates,
|
||||
events_by_sid,
|
||||
infer_timestamps=infer_timestamps,
|
||||
dataset=dataset,
|
||||
)
|
||||
|
||||
|
||||
dtx = pd.date_range('2014-01-01', '2014-01-10')
|
||||
|
||||
|
||||
def assert_loader_error(events_by_sid, error, msg, infer_timestamps=True):
|
||||
with assertRaises(error) as context:
|
||||
EventDataSetLoader(
|
||||
dtx, events_by_sid, infer_timestamps=infer_timestamps,
|
||||
)
|
||||
assert msg in context.exception
|
||||
|
||||
|
||||
class EventLoaderTestCase(TestCase):
|
||||
|
||||
def test_no_expected_cols_defined(self):
|
||||
events_by_sid = {0: pd.DataFrame({ANNOUNCEMENT_FIELD_NAME: dtx})}
|
||||
assert_loader_error(events_by_sid, TypeError, ABSTRACT_METHODS_ERROR)
|
||||
|
||||
def test_wrong_cols(self):
|
||||
wrong_col_name = 'some_other_col'
|
||||
# Test wrong cols (cols != expected)
|
||||
events_by_sid = {0: pd.DataFrame({wrong_col_name: dtx})}
|
||||
assert_loader_error(
|
||||
events_by_sid, ValueError, WRONG_COLS_ERROR % (
|
||||
EventDataSetLoader.expected_cols, 0, wrong_col_name
|
||||
)
|
||||
)
|
||||
|
||||
@parameterized.expand([
|
||||
# DataFrame without timestamp column and infer_timestamps = True
|
||||
[pd.DataFrame({ANNOUNCEMENT_FIELD_NAME: dtx}), True],
|
||||
# DataFrame with timestamp column
|
||||
[pd.DataFrame({ANNOUNCEMENT_FIELD_NAME: dtx,
|
||||
TS_FIELD_NAME: dtx}), False],
|
||||
# DatetimeIndex with infer_timestamps = True
|
||||
[pd.DatetimeIndex(dtx, name=ANNOUNCEMENT_FIELD_NAME), True],
|
||||
# Series with DatetimeIndex as index and infer_timestamps = False
|
||||
[pd.Series(dtx, index=dtx, name=ANNOUNCEMENT_FIELD_NAME), False]
|
||||
])
|
||||
def test_conversion_to_df(self, df, infer_timestamps):
|
||||
|
||||
events_by_sid = {0: df}
|
||||
loader = EventDataSetLoader(
|
||||
dtx,
|
||||
events_by_sid,
|
||||
infer_timestamps=infer_timestamps,
|
||||
)
|
||||
self.assertEqual(
|
||||
loader.events_by_sid.keys(),
|
||||
events_by_sid.keys(),
|
||||
)
|
||||
|
||||
if infer_timestamps:
|
||||
expected = pd.Series(index=[dtx[0]] * 10, data=dtx, )
|
||||
else:
|
||||
expected = pd.Series(index=dtx, data=dtx,)
|
||||
# Check that index by first given date has been added
|
||||
assert_series_equal(
|
||||
loader.events_by_sid[0][ANNOUNCEMENT_FIELD_NAME],
|
||||
expected,
|
||||
check_names=False
|
||||
)
|
||||
|
||||
@parameterized.expand([
|
||||
# DataFrame without timestamp column and infer_timestamps = True
|
||||
[pd.DataFrame({ANNOUNCEMENT_FIELD_NAME: dtx}), False,
|
||||
DF_NO_TS_NOT_INFER_TS_ERROR % (TS_FIELD_NAME, 0)],
|
||||
# DatetimeIndex with infer_timestamps = False
|
||||
[pd.DatetimeIndex(dtx, name=ANNOUNCEMENT_FIELD_NAME), False,
|
||||
DTINDEX_NOT_INFER_TS_ERROR % 0],
|
||||
# Series with DatetimeIndex as index and infer_timestamps = False
|
||||
[pd.Series(dtx, name=ANNOUNCEMENT_FIELD_NAME), False,
|
||||
SERIES_NO_DTINDEX_ERROR % 0],
|
||||
# Some other data structure that is not expected
|
||||
[dtx, False, BAD_DATA_FORMAT_ERROR % 0],
|
||||
[dtx, True, BAD_DATA_FORMAT_ERROR % 0]
|
||||
])
|
||||
def test_bad_conversion_to_df(self, df, infer_timestamps, msg):
|
||||
events_by_sid = {0: df}
|
||||
assert_loader_error(events_by_sid, ValueError, msg,
|
||||
infer_timestamps=infer_timestamps)
|
||||
|
||||
|
||||
class BlazeEventDataSetLoaderNoConcreteLoader(BlazeEventsLoader):
|
||||
def __init__(self,
|
||||
expr,
|
||||
dataset=EventDataSet,
|
||||
**kwargs):
|
||||
super(
|
||||
BlazeEventDataSetLoaderNoConcreteLoader, self
|
||||
).__init__(expr,
|
||||
dataset=dataset,
|
||||
**kwargs)
|
||||
|
||||
|
||||
class BlazeEventLoaderTestCase(TestCase):
|
||||
# Blaze loader: need to test failure if no concrete loader
|
||||
def test_no_concrete_loader_defined(self):
|
||||
with assertRaises(TypeError) as context:
|
||||
BlazeEventDataSetLoaderNoConcreteLoader(
|
||||
bz.Data(
|
||||
pd.DataFrame({ANNOUNCEMENT_FIELD_NAME: dtx,
|
||||
SID_FIELD_NAME: 0
|
||||
})
|
||||
)
|
||||
)
|
||||
assert ABSTRACT_METHODS_ERROR in context.exception
|
||||
|
||||
Reference in New Issue
Block a user