From 12c7cd3b41343046a9e16bd52b3f89abb843a87e Mon Sep 17 00:00:00 2001 From: fawce Date: Thu, 2 Aug 2012 15:40:26 -0400 Subject: [PATCH] removed extraneous imports to remove circularity --- tests/test_components.py | 4 +--- zipline/core/component.py | 14 +++----------- zipline/lines.py | 2 +- 3 files changed, 5 insertions(+), 15 deletions(-) diff --git a/tests/test_components.py b/tests/test_components.py index a9b765d0..9be71304 100644 --- a/tests/test_components.py +++ b/tests/test_components.py @@ -70,9 +70,7 @@ class ComponentTestCase(TestCase): } comp_a = Component( - SpecificEquityTrades, - args_a, - kwargs_a, + SpecificEquityTrades(*args_a, **kwargs_a), monitor, socket_uri, DATASOURCE_FRAME, diff --git a/zipline/core/component.py b/zipline/core/component.py index 287373b4..b76e78cf 100644 --- a/zipline/core/component.py +++ b/zipline/core/component.py @@ -13,7 +13,6 @@ import humanhash import multiprocessing from setproctitle import setproctitle from collections import namedtuple -from zipline.gens.utils import hash_args # pyzmq @@ -48,9 +47,7 @@ class Component(object): # ------------ def __init__(self, - gen_func, - gen_args, - gen_kwargs, + generator, component_id, monitor, socket_uri, @@ -66,13 +63,9 @@ class Component(object): # ----------------- # Generator # ----------------- - self.gen_args = gen_args - self.gen_kwargs = gen_kwargs - self.gen_func = gen_func - self.generator = None + self.generator = generator self.frame = frame - self.component_id = self.gen_func.__name__ \ - + hash_args(gen_args, gen_kwargs) + self.component_id = hash(self.generator) # lock for waiting on monitor "GO" self.waiting = None @@ -503,7 +496,6 @@ class Component(object): self.setup_control() if send: - self.generator = self.gen_func(*self.gen_args, **self.gen_kwargs) self.out_socket = self.open_socket(self.out_socket_args) self.sockets.extend([self.out_socket]) else: diff --git a/zipline/lines.py b/zipline/lines.py index 3d3ab2a6..a5a3858e 100644 --- a/zipline/lines.py +++ b/zipline/lines.py @@ -62,7 +62,7 @@ before invoking simulate. import inspect import logbook -import zipline.utils.factory as factory +#import zipline.utils.factory as factory from zipline.components import DataSource from zipline.transforms import BaseTransform