wassname/catalyst
1
0
Fork 0
mirror of https://github.com/wassname/catalyst.git synced 2026-07-29 11:18:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

BUG: F.window_safe implies f.demean().window_safe.

Browse Source
This commit is contained in:
Scott Sanderson
2016-09-22 12:41:50 -04:00
parent a5c7e93540
commit bddb453272
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/pipeline/test_factor.py
+11
View File
@@ -1047,3 +1047,14 @@ class ShortReprTestCase(TestCase):
def test_zscore(self):
r = F().zscore().short_repr()
self.assertEqual(r, "GroupedRowTransform('zscore')")
class TestWindowSafety(TestCase):
def test_zscore_is_window_safe(self):
self.assertTrue(F().zscore().window_safe)
def test_demean_is_window_safe_if_input_is_window_safe(self):
self.assertFalse(F().demean().window_safe)
self.assertFalse(F(window_safe=False).demean().window_safe)
self.assertTrue(F(window_safe=True).demean().window_safe)