MAINT: remove __getitem__ as alias of __getattr__

zipline/test_algorithms.py

@@ -62,7 +62,7 @@ The algorithm must expose methods:
     algorithm can then check position information with the
     Portfolio object::
 
-        self.Portfolio[sid(133)]['cost_basis']
+        self.Portfolio[sid(133)].cost_basis
 
   - set_transact_setter: method that accepts a callable. Will
     be set as the value of the set_transact_setter method of
@@ -261,9 +261,9 @@ class TestOrderAlgorithm(TradingAlgorithm):
         if self.incr == 0:
             assert 0 not in self.portfolio.positions
         else:
-            assert self.portfolio.positions[0]['amount'] == \
+            assert self.portfolio.positions[0].amount == \
                 self.incr, "Orders not filled immediately."
-            assert self.portfolio.positions[0]['last_sale_price'] == \
+            assert self.portfolio.positions[0].last_sale_price == \
                 data.current(sid(0), "price"), \
                 "Orders not filled at current price."
         self.incr += 1
@@ -279,9 +279,9 @@ class TestOrderInstantAlgorithm(TradingAlgorithm):
         if self.incr == 0:
             assert 0 not in self.portfolio.positions
         else:
-            assert self.portfolio.positions[0]['amount'] == \
+            assert self.portfolio.positions[0].amount == \
                 self.incr, "Orders not filled immediately."
-            assert self.portfolio.positions[0]['last_sale_price'] == \
+            assert self.portfolio.positions[0].last_sale_price == \
                 self.last_price, "Orders was not filled at last price."
         self.incr += 1
         self.order_value(self.sid(0), data.current(sid(0), "price"))
@@ -330,9 +330,9 @@ class TestOrderValueAlgorithm(TradingAlgorithm):
         if self.incr == 0:
             assert 0 not in self.portfolio.positions
         else:
-            assert self.portfolio.positions[0]['amount'] == \
+            assert self.portfolio.positions[0].amount == \
                 self.incr, "Orders not filled immediately."
-            assert self.portfolio.positions[0]['last_sale_price'] == \
+            assert self.portfolio.positions[0].last_sale_price == \
                 data.current(sid(0), "price"), \
                 "Orders not filled at current price."
         self.incr += 2
@@ -357,9 +357,9 @@ class TestTargetAlgorithm(TradingAlgorithm):
         if self.target_shares == 0:
             assert 0 not in self.portfolio.positions
         else:
-            assert self.portfolio.positions[0]['amount'] == \
+            assert self.portfolio.positions[0].amount == \
                 self.target_shares, "Orders not filled immediately."
-            assert self.portfolio.positions[0]['last_sale_price'] == \
+            assert self.portfolio.positions[0].last_sale_price == \
                 data.current(sid(0), "price"), \
                 "Orders not filled at current price."
         self.target_shares = 10
@@ -380,9 +380,9 @@ class TestOrderPercentAlgorithm(TradingAlgorithm):
             return
         else:
 
-            assert self.portfolio.positions[0]['amount'] == \
+            assert self.portfolio.positions[0].amount == \
                 self.target_shares, "Orders not filled immediately."
-            assert self.portfolio.positions[0]['last_sale_price'] == \
+            assert self.portfolio.positions[0].last_sale_price == \
                 data.current(sid(0), "price"), \
                 "Orders not filled at current price."
 
@@ -418,13 +418,13 @@ class TestTargetPercentAlgorithm(TradingAlgorithm):
             # no more than a share's value away from our current
             # holdings.
             target_value = self.portfolio.portfolio_value * 0.002
-            position_value = self.portfolio.positions[0]['amount'] * \
+            position_value = self.portfolio.positions[0].amount * \
                 self.sale_price
 
             assert abs(target_value - position_value) <= self.sale_price, \
                 "Orders not filled correctly"
 
-            assert self.portfolio.positions[0]['last_sale_price'] == \
+            assert self.portfolio.positions[0].last_sale_price == \
                 data.current(sid(0), "price"), \
                 "Orders not filled at current price."
 
@@ -446,9 +446,9 @@ class TestTargetValueAlgorithm(TradingAlgorithm):
             self.target_shares = 10
             return
         else:
-            assert self.portfolio.positions[0]['amount'] == \
+            assert self.portfolio.positions[0].amount == \
                 self.target_shares, "Orders not filled immediately."
-            assert self.portfolio.positions[0]['last_sale_price'] == \
+            assert self.portfolio.positions[0].last_sale_price == \
                 data.current(sid(0), "price"), \
                 "Orders not filled at current price."
 
@@ -763,9 +763,9 @@ def handle_data_api(context, data):
     if context.incr == 0:
         assert 0 not in context.portfolio.positions
     else:
-        assert context.portfolio.positions[0]['amount'] == \
+        assert context.portfolio.positions[0].amount == \
             context.incr, "Orders not filled immediately."
-        assert context.portfolio.positions[0]['last_sale_price'] == \
+        assert context.portfolio.positions[0].last_sale_price == \
             data.current(sid(0), "price"), \
             "Orders not filled at current price."
     context.incr += 1
@@ -805,9 +805,9 @@ def handle_data(context, data):
     if context.incr == 0:
         assert 0 not in context.portfolio.positions
     else:
-        assert context.portfolio.positions[0]['amount'] == \
+        assert context.portfolio.positions[0].amount == \
                 context.incr, "Orders not filled immediately."
-        assert context.portfolio.positions[0]['last_sale_price'] == \
+        assert context.portfolio.positions[0].last_sale_price == \
                 data.current(sid(0), "price"), \
                 "Orders not filled at current price."
     context.incr += 1