From 56937e1b18a575b85dd8d8832917903ca1754d87 Mon Sep 17 00:00:00 2001
From: wassname <1103714+wassname@users.noreply.github.com>
Date: Tue, 19 May 2026 19:11:32 +0800
Subject: [PATCH] remove dead code: _road_matrix, callable(m) clause, silent
 git fallback

- delete _road_matrix in variants/road.py (zero callers)
- drop redundant callable(m) clause in is_linear_like (every nn.Module is callable)
- remove try/except in current_git_commit so missing git crashes loudly
  instead of writing "unknown" into the results TSV

Co-Authored-By: Claudypoo <noreply@anthropic.com>
---
 scripts/metamath_gsm8k_benchmark.py |  5 +----
 src/lora_lite/target.py             |  1 -
 src/lora_lite/variants/road.py      | 16 ----------------
 3 files changed, 1 insertion(+), 21 deletions(-)

diff --git a/scripts/metamath_gsm8k_benchmark.py b/scripts/metamath_gsm8k_benchmark.py
index 2bf0f08..eca46d7 100644
--- a/scripts/metamath_gsm8k_benchmark.py
+++ b/scripts/metamath_gsm8k_benchmark.py
@@ -457,10 +457,7 @@ def print_final_report(row: dict[str, Any], result_path: Path, mode: str) -> Non
 
 
 def current_git_commit() -> str:
-    try:
-        return subprocess.check_output(["git", "rev-parse", "HEAD"], text=True).strip()
-    except (subprocess.CalledProcessError, FileNotFoundError):
-        return "unknown"
+    return subprocess.check_output(["git", "rev-parse", "HEAD"], text=True).strip()
 
 
 def append_results_row(
diff --git a/src/lora_lite/target.py b/src/lora_lite/target.py
index be2aa53..32eaee4 100644
--- a/src/lora_lite/target.py
+++ b/src/lora_lite/target.py
@@ -13,7 +13,6 @@ def is_linear_like(m: nn.Module) -> bool:
         hasattr(m, "in_features")
         and hasattr(m, "out_features")
         and hasattr(m, "weight")
-        and callable(m)
     )
 
 
diff --git a/src/lora_lite/variants/road.py b/src/lora_lite/variants/road.py
index 6042576..65ac056 100644
--- a/src/lora_lite/variants/road.py
+++ b/src/lora_lite/variants/road.py
@@ -92,22 +92,6 @@ def _apply_road(
     return y * first_col + rotate_half_y * second_col
 
 
-def _road_matrix(
-    road_variant: str,
-    group_size: int,
-    road_theta: torch.Tensor,
-    road_alpha: torch.Tensor,
-) -> torch.Tensor:
-    """Explicit PEFT merge matrix. Used for tests and small-debug inspection."""
-    first_col, second_col = _prepare_cols(road_variant, group_size, road_theta, road_alpha)
-    size = second_col.shape[0]
-    output = torch.diag(first_col)
-    swapped_second_col = second_col.reshape(-1, 2, group_size // 2)[:, [1, 0], :].flatten()
-    rotated_diag_second_col = torch.diag(swapped_second_col).reshape(-1, 2, group_size // 2, size)[:, [1, 0], :, :]
-    rotated_diag_second_col[:, 0, :, :] *= -1
-    return output + rotated_diag_second_col.reshape(size, size)
-
-
 @register
 class ROAD:
     name = "road"