From 0b9af15c741e9a4a3f594bbe14ae3fcdade1fdbf Mon Sep 17 00:00:00 2001
From: Harman Waseer <2403hwaseer@gmail.com>
Date: Tue, 16 Mar 2021 22:38:19 +0530
Subject: [PATCH] Merge the loops assigning paramValues and paramIndices

---
 optuna_dashboard/static/components/GraphContour.tsx | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/optuna_dashboard/static/components/GraphContour.tsx b/optuna_dashboard/static/components/GraphContour.tsx
index c8daae3c..5d26a7ed 100644
--- a/optuna_dashboard/static/components/GraphContour.tsx
+++ b/optuna_dashboard/static/components/GraphContour.tsx
@@ -28,8 +28,6 @@ const getParamNames = (trials: Trial[]): string[] => {
   return Array.from(paramSet)
 }
 
-
-
 export const GraphContour: FC<{
   study: StudyDetail | null
 }> = ({ study = null }) => {
@@ -37,8 +35,8 @@ export const GraphContour: FC<{
   const filteredTrials = trials.filter(
     (t) => t.state === "Complete" || t.state === "Pruned"
   )
-  
-  const paramArray = getParamNames(filteredTrials)  
+
+  const paramArray = getParamNames(filteredTrials)
 
   const classes = useStyles()
   const [objectiveId, setObjectiveId] = useState<number>(0)
@@ -177,14 +175,10 @@ const plotContour = (
         return param!.value
       })
       paramValues[i] = valueStrings
+      paramIndices[i] = paramName
       i++
     })
 
-    let k = 0
-    paramNames.forEach((paramName) => {
-      paramIndices[k] = paramName
-      k++
-    })
     const paramCategorical = { ...paramValues }
     const xIndex = paramIndices.indexOf(xAxis)
     const yIndex = paramIndices.indexOf(yAxis)