wassname/optuna-dashboard
1
0
Fork 0
mirror of https://github.com/wassname/optuna-dashboard.git synced 2026-09-10 12:23:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix tests

Browse Source
This commit is contained in:
c-bata
2023-09-07 10:54:21 +09:00
parent e3b7e1d893
commit 167a4de6c4
2 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
optuna_dashboard/_custom_plot_data.py
+5 -7
View File
@@ -53,7 +53,7 @@ def save_plotly_graph_object(
Returns:
The graph object ID.
"""
if graph_object_id is not None and not is_valid_html_name(graph_object_id):
if graph_object_id is not None and not is_valid_graph_object_id(graph_object_id):
raise ValueError("graph_object_id must be a valid HTML id attribute value.")
storage = study._storage
@@ -119,18 +119,16 @@ def concat_plot_data(plot_data_attrs: dict[str, str], key_prefix: str) -> str:
return "".join(plot_data_attrs[f"{key_prefix}{i}"] for i in range(len(plot_data_attrs)))
def is_valid_html_name(graph_object_id: str) -> bool:
def is_valid_graph_object_id(graph_object_id: str) -> bool:
if len(graph_object_id) == 0:
return False
# Must begin with a letter [A-Za-z]
if not ("a" <= graph_object_id[0] <= "z" or "A" <= graph_object_id[0] <= "Z"):
return False
# Can only contain letters [A-Za-z], numbers [0-9], hyphens ("-"), underscores ("_"), colons, and periods.
# Can only contain letters [A-Za-z], numbers [0-9], hyphens ("-"), underscores ("_"),
# colons, and periods.
if not all(
"a" <= c <= "z" or "A" <= c <= "Z" or "0" <= c <= "9" or c in ("-", "_", ":", ".")
for c in graph_object_id[1:]
):
return False
# Unlike HTML id attribute, graph object id can begin with a letter [A-Za-z]
return True