From 18b188b06c20f213aba26971cfd892bc33a06faa Mon Sep 17 00:00:00 2001 From: c-bata Date: Fri, 1 Mar 2024 22:29:23 +0900 Subject: [PATCH] Fix lint error and revert debug logs --- vscode/CHANGELOG.md | 12 +++++------- vscode/package-lock.json | 4 ++-- vscode/package.json | 2 +- vscode/src/web/extension.ts | 25 ++++++++++--------------- 4 files changed, 18 insertions(+), 25 deletions(-) diff --git a/vscode/CHANGELOG.md b/vscode/CHANGELOG.md index 0b2084bc..73d0021a 100644 --- a/vscode/CHANGELOG.md +++ b/vscode/CHANGELOG.md @@ -6,19 +6,17 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how ## [Unreleased] -## 0.2.1 - -* Enable a "Open in Optuna Dashboard" menu for `.log` files. -* Fix a bug that the extension cannot show studies on the first attempt. +* [bug] Fix a bug that the extension cannot show studies on the first attempt. +* [feature] Enable a "Open in Optuna Dashboard" menu for `.log` files. ## 0.2.0 -* Added support for `JournalFileStorage`. -* Added support for code-server. +* [feature] Added support for `JournalFileStorage`. +* [feature] Added support for code-server. ## 0.1.0 -* Added older database schemas support (Optuna 2.6.0 or later) +* [feature] Added older database schemas support (Optuna 2.6.0 or later) ## 0.0.1 diff --git a/vscode/package-lock.json b/vscode/package-lock.json index 340a8bdb..ac6837b4 100644 --- a/vscode/package-lock.json +++ b/vscode/package-lock.json @@ -1,12 +1,12 @@ { "name": "optuna-dashboard", - "version": "0.2.1", + "version": "0.2.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "optuna-dashboard", - "version": "0.2.1", + "version": "0.2.0", "license": "MIT", "devDependencies": { "@types/mocha": "^10.0.1", diff --git a/vscode/package.json b/vscode/package.json index a3cb4a56..e5ee047a 100644 --- a/vscode/package.json +++ b/vscode/package.json @@ -3,7 +3,7 @@ "displayName": "Optuna Dashboard", "description": "Web Dashboard for Optuna", "publisher": "Optuna", - "version": "0.2.1", + "version": "0.2.0", "license": "MIT", "icon": "images/optuna-logo.png", "engines": { diff --git a/vscode/src/web/extension.ts b/vscode/src/web/extension.ts index 62dcaec8..914f35ba 100644 --- a/vscode/src/web/extension.ts +++ b/vscode/src/web/extension.ts @@ -30,20 +30,17 @@ export function activate(context: vscode.ExtensionContext) { const appPath = panel.webview.asWebviewUri(indexJsUri) panel.webview.html = getWebviewContent(appPath) - panel.webview.onDidReceiveMessage( - async (message: any) => { - switch (message.type) { - case 'webviewDidLoad': - console.log("[host] Receive a webviewDidLoad event.") - const storageContentBase64 = await readFileAsBase64(fileUri) - panel.webview.postMessage({ - type: "optunaStorage", - content: storageContentBase64, - }) - break - } + panel.webview.onDidReceiveMessage(async (message: any) => { + switch (message.type) { + case "webviewDidLoad": + const storageContentBase64 = await readFileAsBase64(fileUri) + panel.webview.postMessage({ + type: "optunaStorage", + content: storageContentBase64, + }) + break } - ); + }) } ) @@ -66,7 +63,6 @@ function uint8ArrayToBase64(uint8Array: Uint8Array): string { } function getWebviewContent(indexJsUri: vscode.Uri): string { - // https://code.visualstudio.com/api/extension-guides/webview#passing-messages-from-a-webview-to-an-extension return ` @@ -78,7 +74,6 @@ function getWebviewContent(indexJsUri: vscode.Uri): string { const vscodeApi = acquireVsCodeApi(); window.addEventListener('DOMContentLoaded', (event) => { vscodeApi.postMessage({ type: 'webviewDidLoad' }) - console.log("[webview] Post a webviewDidLoad event.") }) }())