From 1c4037ffce229e69fdfec852956ce29f49a33d5e Mon Sep 17 00:00:00 2001 From: Naoto Mizuno Date: Fri, 22 Sep 2023 16:34:20 +0900 Subject: [PATCH] Skip test for Python 3.7 --- python_tests/preferential/test_samplers.py | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/python_tests/preferential/test_samplers.py b/python_tests/preferential/test_samplers.py index 00b74ded..2de8864c 100644 --- a/python_tests/preferential/test_samplers.py +++ b/python_tests/preferential/test_samplers.py @@ -1,6 +1,7 @@ from __future__ import annotations from collections.abc import Callable +import sys import optuna from optuna import create_trial @@ -10,12 +11,26 @@ from optuna.distributions import IntDistribution from optuna.samplers import BaseSampler from optuna.trial import TrialState from optuna_dashboard.preferential import create_study -from optuna_dashboard.preferential.samplers.gp import PreferentialGPSampler import pytest +if sys.version_info >= (3, 8): + from optuna_dashboard.preferential.samplers.gp import PreferentialGPSampler +else: + PreferentialGPSampler = None + + parametrize_sampler = pytest.mark.parametrize( - "sampler_class", [optuna.samplers.RandomSampler, PreferentialGPSampler] + "sampler_class", + [ + optuna.samplers.RandomSampler, + pytest.param( + PreferentialGPSampler, + marks=pytest.mark.skipif( + sys.version_info < (3, 8), reason="BoTorch dropped Python3.7 support" + ), + ), + ], )