From 1f7799fb47d2ced8744fa4ee8cc664fb5c2c19de Mon Sep 17 00:00:00 2001
From: c-bata <contact@c-bata.link>
Date: Tue, 22 Mar 2022 08:35:00 +0900
Subject: [PATCH] Fix a memory leak in GraphHyperparameterImportance

---
 .../ts/components/GraphHyperparameterImportances.tsx      | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/optuna_dashboard/ts/components/GraphHyperparameterImportances.tsx b/optuna_dashboard/ts/components/GraphHyperparameterImportances.tsx
index a776f4e3..c4713b80 100644
--- a/optuna_dashboard/ts/components/GraphHyperparameterImportances.tsx
+++ b/optuna_dashboard/ts/components/GraphHyperparameterImportances.tsx
@@ -57,8 +57,8 @@ export const GraphHyperparameterImportances: FC<{
   }
 
   useEffect(() => {
-    async function fetchParamImportances(studyId: number, objectiveId: number) {
-      await getParamImportances(studyId, objectiveId)
+    if (numCompletedTrials > 0) {
+      getParamImportances(studyId, objectiveId)
         .then((p) => {
           setImportances(p)
         })
@@ -72,10 +72,6 @@ export const GraphHyperparameterImportances: FC<{
           )
         })
     }
-
-    if (numCompletedTrials > 0) {
-      fetchParamImportances(studyId, objectiveId)
-    }
   }, [numCompletedTrials, objectiveId, theme.palette.mode])
 
   useEffect(() => {