From 22d4207c16467759c3e0b7addecca1e2da8426f4 Mon Sep 17 00:00:00 2001
From: c-bata <contact@c-bata.link>
Date: Wed, 25 May 2022 21:28:30 +0900
Subject: [PATCH] Fix comparator function

---
 .../ts/components/StudyDetail.tsx             | 26 +++++++++++++------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/optuna_dashboard/ts/components/StudyDetail.tsx b/optuna_dashboard/ts/components/StudyDetail.tsx
index 21f91de3..1ea24675 100644
--- a/optuna_dashboard/ts/components/StudyDetail.tsx
+++ b/optuna_dashboard/ts/components/StudyDetail.tsx
@@ -515,13 +515,18 @@ export const TrialTable: FC<{ studyDetail: StudyDetail | null }> = ({
 
         if (firstVal === secondVal) {
           return 0
-        } else if (firstVal && secondVal) {
-          return firstVal < secondVal ? 1 : -1
-        } else if (firstVal) {
+        }
+        if (firstVal === undefined) {
           return -1
-        } else {
+        } else if (secondVal === undefined) {
           return 1
         }
+        if (firstVal === "-inf" || secondVal === "inf") {
+          return 1
+        } else if (secondVal === "-inf" || firstVal === "inf") {
+          return -1
+        }
+        return firstVal < secondVal ? 1 : -1
       },
       toCellValue: (i) => {
         if (trials[i].values === undefined) {
@@ -542,13 +547,18 @@ export const TrialTable: FC<{ studyDetail: StudyDetail | null }> = ({
 
           if (firstVal === secondVal) {
             return 0
-          } else if (firstVal && secondVal) {
-            return firstVal < secondVal ? 1 : -1
-          } else if (firstVal) {
+          }
+          if (firstVal === undefined) {
             return -1
-          } else {
+          } else if (secondVal === undefined) {
             return 1
           }
+          if (firstVal === "-inf" || secondVal === "inf") {
+            return 1
+          } else if (secondVal === "-inf" || firstVal === "inf") {
+            return -1
+          }
+          return firstVal < secondVal ? 1 : -1
         },
         toCellValue: (i) => {
           if (trials[i].values === undefined) {