From 44a7b8a5401c91d17686a060a9864a9a1999c67d Mon Sep 17 00:00:00 2001 From: c-bata Date: Mon, 7 Aug 2023 10:10:17 +0900 Subject: [PATCH] Fix broken tests --- optuna_dashboard/artifact/_backend.py | 4 +--- python_tests/artifact/test_optuna_compatibility.py | 10 ++++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/optuna_dashboard/artifact/_backend.py b/optuna_dashboard/artifact/_backend.py index 313b0130..f5c39caa 100644 --- a/optuna_dashboard/artifact/_backend.py +++ b/optuna_dashboard/artifact/_backend.py @@ -208,9 +208,7 @@ def get_artifact_meta( return None -def delete_all_artifacts( - backend: ArtifactBackend, storage: BaseStorage, study_id: int -) -> None: +def delete_all_artifacts(backend: ArtifactStore, storage: BaseStorage, study_id: int) -> None: artifact_metas = [] study_system_attrs = storage.get_study_system_attrs(study_id) for trial in storage.get_all_trials(study_id): diff --git a/python_tests/artifact/test_optuna_compatibility.py b/python_tests/artifact/test_optuna_compatibility.py index 7f6cd264..01742bac 100644 --- a/python_tests/artifact/test_optuna_compatibility.py +++ b/python_tests/artifact/test_optuna_compatibility.py @@ -5,8 +5,8 @@ import tempfile import optuna from optuna.version import __version__ as optuna_ver +from optuna_dashboard.artifact._backend import delete_all_artifacts from optuna_dashboard.artifact._backend import get_artifact_meta -from optuna_dashboard.artifact._backend import list_study_artifacts from optuna_dashboard.artifact._backend import list_trial_artifacts from packaging import version import pytest @@ -57,7 +57,7 @@ def test_list_optuna_trial_artifacts() -> None: version.parse(optuna_ver) < version.Version("3.3.0.dev"), reason="Artifact is not implemented yet in Optuna", ) -def test_list_optuna_study_artifacts() -> None: +def test_delete_optuna_study_artifacts() -> None: from optuna.artifacts import FileSystemArtifactStore from optuna.artifacts import upload_artifact @@ -77,5 +77,7 @@ def test_list_optuna_study_artifacts() -> None: return 0.0 study.optimize(objective, n_trials=10) - artifact_meta_list = list_study_artifacts(storage, study_id=study._study_id) - assert len(artifact_meta_list) == 10 + assert len(os.listdir(tmpdir)) == 11 # 10 artifacts + dummy.txt + + delete_all_artifacts(artifact_store, storage, study._study_id) + assert len(os.listdir(tmpdir)) == 1 # dummy.txt only