Fix mypy errors in Optuna 4.0+

This commit is contained in:
c-bata
2024-09-11 16:32:38 +09:00
parent 7d6b619212
commit 5a1d6365cd
4 changed files with 27 additions and 9 deletions
+12 -4
View File
@@ -142,7 +142,9 @@ def test_successful_study_artifact_retrieval() -> None:
with tempfile.NamedTemporaryFile() as f:
f.write(b"dummy_content")
f.flush()
artifact_id = upload_artifact(study, f.name, artifact_store=artifact_store)
artifact_id = upload_artifact(
study_or_trial=study, file_path=f.name, artifact_store=artifact_store
)
app = create_app(storage, artifact_store)
status, _, body = send_request(
app,
@@ -188,7 +190,9 @@ def test_successful_trial_artifact_retrieval() -> None:
with tempfile.NamedTemporaryFile() as f:
f.write(b"dummy_content")
f.flush()
artifact_id = upload_artifact(trial, f.name, artifact_store=artifact_store)
artifact_id = upload_artifact(
study_or_trial=trial, file_path=f.name, artifact_store=artifact_store
)
app = create_app(storage, artifact_store)
status, _, body = send_request(
app,
@@ -281,7 +285,9 @@ def test_delete_study_artifact() -> None:
with tempfile.NamedTemporaryFile() as f:
f.write(b"dummy_content")
f.flush()
artifact_id = upload_artifact(study, f.name, artifact_store=artifact_store)
artifact_id = upload_artifact(
study_or_trial=study, file_path=f.name, artifact_store=artifact_store
)
app = create_app(storage, artifact_store)
status, _, _ = send_request(
app,
@@ -306,7 +312,9 @@ def test_delete_trial_artifact() -> None:
with tempfile.NamedTemporaryFile() as f:
f.write(b"dummy_content")
f.flush()
artifact_id = upload_artifact(trial, f.name, artifact_store=artifact_store)
artifact_id = upload_artifact(
study_or_trial=trial, file_path=f.name, artifact_store=artifact_store
)
app = create_app(storage, artifact_store)
status, _, _ = send_request(
app,
@@ -31,7 +31,7 @@ def test_list_optuna_trial_artifacts() -> None:
with tempfile.NamedTemporaryFile() as f:
f.write(dummy_content)
f.flush()
upload_artifact(trial, f.name, artifact_store=artifact_store)
upload_artifact(study_or_trial=trial, file_path=f.name, artifact_store=artifact_store)
study.tell(trial, 0.0)
@@ -76,7 +76,9 @@ def test_delete_optuna_study_artifacts() -> None:
artifact_store = FileSystemArtifactStore(tmpdir)
def objective(trial: optuna.Trial) -> float:
upload_artifact(trial, dummy_file_path, artifact_store=artifact_store)
upload_artifact(
study_or_trial=trial, file_path=dummy_file_path, artifact_store=artifact_store
)
return 0.0
study.optimize(objective, n_trials=10)
+6 -2
View File
@@ -539,7 +539,9 @@ class APITestCase(TestCase):
with tempfile.NamedTemporaryFile() as f:
f.write(b"dummy")
f.flush()
artifact_id = upload_artifact(study, f.name, artifact_store)
artifact_id = upload_artifact(
study_or_trial=study, file_path=f.name, artifact_store=artifact_store
)
app = create_app(storage, artifact_store)
@@ -575,7 +577,9 @@ class APITestCase(TestCase):
with tempfile.NamedTemporaryFile() as f:
f.write(b"dummy")
f.flush()
artifact_id = upload_artifact(study, f.name, artifact_store)
artifact_id = upload_artifact(
study_or_trial=study, file_path=f.name, artifact_store=artifact_store
)
app = create_app(storage, artifact_store)
+5 -1
View File
@@ -10,6 +10,8 @@ from optuna_dashboard._storage import trials_last_fetched_at
if typing.TYPE_CHECKING:
from sys import _OptExcInfo
from _typeshed.wsgi import WSGIEnvironment
@@ -64,7 +66,9 @@ def send_request(
status: str = ""
response_headers: list[tuple[str, str]] = []
def start_response(status_: str, headers_: list[tuple[str, str]]) -> None:
def start_response(
status_: str, headers_: list[tuple[str, str]], exc_info: _OptExcInfo | None = None
) -> None:
nonlocal status, response_headers
status = status_
response_headers = headers_