From 5fbbb16746b448340cd2feee415004969f305dcc Mon Sep 17 00:00:00 2001 From: keisuke-umezawa Date: Tue, 30 May 2023 22:40:55 +0900 Subject: [PATCH] Rename GraphEdfMultiStudies into GraphEdf --- optuna_dashboard/ts/components/CompareStudies.tsx | 9 +++------ optuna_dashboard/ts/components/GraphEdf.tsx | 6 +++--- optuna_dashboard/ts/components/StudyDetail.tsx | 7 ++----- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/optuna_dashboard/ts/components/CompareStudies.tsx b/optuna_dashboard/ts/components/CompareStudies.tsx index 7cb6bd85..0354297e 100644 --- a/optuna_dashboard/ts/components/CompareStudies.tsx +++ b/optuna_dashboard/ts/components/CompareStudies.tsx @@ -27,8 +27,8 @@ import HomeIcon from "@mui/icons-material/Home" import { actionCreator } from "../action" import { studySummariesState, studyDetailsState } from "../state" import { AppDrawer } from "./AppDrawer" -import { GraphEdfMultiStudies } from "./GraphEdf" -import { GraphHistory } from "./GraphHistory" +import { GraphEdf } from "./GraphEdf" +import { GraphHistoryMultiStudies } from "./GraphHistory" import { useNavigate, useLocation } from "react-router-dom" const useQuery = (): URLSearchParams => { @@ -334,10 +334,7 @@ const StudiesGraph: FC<{ studies: StudySummary[] }> = ({ studies }) => { - + diff --git a/optuna_dashboard/ts/components/GraphEdf.tsx b/optuna_dashboard/ts/components/GraphEdf.tsx index c0a1513c..ca85ee54 100644 --- a/optuna_dashboard/ts/components/GraphEdf.tsx +++ b/optuna_dashboard/ts/components/GraphEdf.tsx @@ -11,7 +11,7 @@ interface EdfPlotInfo { trials: Trial[] } -export const GraphEdfMultiStudies: FC<{ +export const GraphEdf: FC<{ studies: StudyDetail[] objectiveId: number }> = ({ studies, objectiveId }) => { @@ -31,7 +31,7 @@ export const GraphEdfMultiStudies: FC<{ }) useEffect(() => { - plotEdfMultiStudies(edfPlotInfos, target, domId, theme.palette.mode) + plotEdf(edfPlotInfos, target, domId, theme.palette.mode) }, [studies, target, theme.palette.mode]) return ( @@ -47,7 +47,7 @@ export const GraphEdfMultiStudies: FC<{ ) } -const plotEdfMultiStudies = ( +const plotEdf = ( edfPlotInfos: EdfPlotInfo[], target: Target, domId: string, diff --git a/optuna_dashboard/ts/components/StudyDetail.tsx b/optuna_dashboard/ts/components/StudyDetail.tsx index 9c167094..10f32175 100644 --- a/optuna_dashboard/ts/components/StudyDetail.tsx +++ b/optuna_dashboard/ts/components/StudyDetail.tsx @@ -25,7 +25,7 @@ import { AppDrawer, PageId } from "./AppDrawer" import { GraphParallelCoordinate } from "./GraphParallelCoordinate" import { Contour } from "./GraphContour" import { GraphSlice } from "./GraphSlice" -import { GraphEdfMultiStudies } from "./GraphEdf" +import { GraphEdf } from "./GraphEdf" import { TrialList } from "./TrialList" import { StudyHistory } from "./StudyHistory" @@ -113,10 +113,7 @@ export const StudyDetail: FC<{ - +