wassname/optuna-dashboard
1
0
Fork 0
mirror of https://github.com/wassname/optuna-dashboard.git synced 2026-09-10 12:23:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove TODOs in CachedExtraStudyProperty

Browse Source
This commit is contained in:
c-bata
2023-01-13 21:38:38 +09:00
parent c91bd21036
commit 63ac92a95d
2 changed files with 21 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python_tests/test_cached_extra_study_property.py
+8 -8
View File
@@ -46,8 +46,8 @@ class _CachedExtraStudyPropertySearchSpaceTestCase(TestCase):
cached_extra_study_property = _CachedExtraStudyProperty()
cached_extra_study_property.update(trials)
self.assertEqual(len(cached_extra_study_property.intersection), 2)
self.assertEqual(len(cached_extra_study_property.union), 2)
self.assertEqual(len(cached_extra_study_property.intersection_search_space), 2)
self.assertEqual(len(cached_extra_study_property.union_search_space), 2)
def test_different_distributions(self) -> None:
distributions: list[dict[str, BaseDistribution]] = [
@@ -77,8 +77,8 @@ class _CachedExtraStudyPropertySearchSpaceTestCase(TestCase):
cached_extra_study_property = _CachedExtraStudyProperty()
cached_extra_study_property.update(trials)
self.assertEqual(len(cached_extra_study_property.intersection), 1)
self.assertEqual(len(cached_extra_study_property.union), 3)
self.assertEqual(len(cached_extra_study_property.intersection_search_space), 1)
self.assertEqual(len(cached_extra_study_property.union_search_space), 3)
def test_dynamic_search_space(self) -> None:
distributions: list[dict[str, BaseDistribution]] = [
@@ -115,8 +115,8 @@ class _CachedExtraStudyPropertySearchSpaceTestCase(TestCase):
cached_extra_study_property = _CachedExtraStudyProperty()
cached_extra_study_property.update(trials)
self.assertEqual(len(cached_extra_study_property.intersection), 0)
self.assertEqual(len(cached_extra_study_property.union), 3)
self.assertEqual(len(cached_extra_study_property.intersection_search_space), 0)
self.assertEqual(len(cached_extra_study_property.union_search_space), 3)
def test_contains_failed_trials(self) -> None:
distributions: dict[str, BaseDistribution] = {
@@ -139,8 +139,8 @@ class _CachedExtraStudyPropertySearchSpaceTestCase(TestCase):
cached_extra_study_property = _CachedExtraStudyProperty()
cached_extra_study_property.update(trials)
self.assertEqual(len(cached_extra_study_property.intersection), 2)
self.assertEqual(len(cached_extra_study_property.union), 2)
self.assertEqual(len(cached_extra_study_property.intersection_search_space), 2)
self.assertEqual(len(cached_extra_study_property.union_search_space), 2)
class _CachedExtraStudyPropertyIntermediateTestCase(TestCase):