From 64b29e40be9288aa86bf88e55ee2bb3d659c3473 Mon Sep 17 00:00:00 2001
From: c-bata <contact@c-bata.link>
Date: Thu, 25 May 2023 17:29:56 +0900
Subject: [PATCH] Fix bug of slider widget

---
 optuna_dashboard/ts/components/TrialFormWidgets.tsx | 9 +++------
 optuna_dashboard/ts/types/index.d.ts                | 2 +-
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/optuna_dashboard/ts/components/TrialFormWidgets.tsx b/optuna_dashboard/ts/components/TrialFormWidgets.tsx
index 0f7a6cde..48d5094f 100644
--- a/optuna_dashboard/ts/components/TrialFormWidgets.tsx
+++ b/optuna_dashboard/ts/components/TrialFormWidgets.tsx
@@ -277,6 +277,7 @@ export const useSliderWidget = (
 ): WidgetState => {
   const theme = useTheme()
   const [value, setValue] = useState<number>(widget.min)
+  const defaultStep = 0.01
   const render = () => (
     <FormControl key={key} sx={{ margin: theme.spacing(1, 2) }}>
       <FormLabel>
@@ -291,12 +292,8 @@ export const useSliderWidget = (
           defaultValue={widget.min}
           min={widget.min}
           max={widget.max}
-          step={widget.step}
-          marks={
-            widget.labels === null || widget.labels.length == 0
-              ? true
-              : widget.labels
-          }
+          step={widget.step || defaultStep}
+          marks={widget.labels === null ? undefined : widget.labels}
           valueLabelDisplay="auto"
         />
       </Box>
diff --git a/optuna_dashboard/ts/types/index.d.ts b/optuna_dashboard/ts/types/index.d.ts
index b58786d7..72ba1dea 100644
--- a/optuna_dashboard/ts/types/index.d.ts
+++ b/optuna_dashboard/ts/types/index.d.ts
@@ -139,7 +139,7 @@ type ObjectiveSliderWidget = {
   user_attr_key?: string
   min: number
   max: number
-  step: number
+  step: number | null
   labels:
     | {
         value: number