From 6defaa055ba9383263216cd4385c3560a5098b10 Mon Sep 17 00:00:00 2001 From: i23_moririn2528 Date: Wed, 16 Aug 2023 09:55:07 +0900 Subject: [PATCH] fix updating trial state --- optuna_dashboard/preferential/_system_attrs.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/optuna_dashboard/preferential/_system_attrs.py b/optuna_dashboard/preferential/_system_attrs.py index 214d7466..02e89680 100644 --- a/optuna_dashboard/preferential/_system_attrs.py +++ b/optuna_dashboard/preferential/_system_attrs.py @@ -25,11 +25,11 @@ def report_preferences( trials = storage.get_all_trials(study_id, deepcopy=False) directions = storage.get_study_directions(study_id) values = [0 for _ in directions] - for better, worse in preferences: - for number in (better, worse): - trial_id = trials[number]._trial_id - if storage.check_trial_is_updatable(trial_id, trials[number].state): - storage.set_trial_state_values(trial_id, TrialState.COMPLETE, values) + updated_trials = {num for tpl in preferences for num in tpl} + for number in updated_trials: + trial_id = trials[number]._trial_id + if trials[number].state != TrialState.COMPLETE: + storage.set_trial_state_values(trial_id, TrialState.COMPLETE, values) def get_preferences(