From 78e1e118029c43281e7620bbeacb879c85aa8670 Mon Sep 17 00:00:00 2001 From: nabenabe0928 Date: Fri, 19 Jan 2024 07:38:52 +0100 Subject: [PATCH] Add the force update for disabled live update --- optuna_dashboard/_app.py | 3 ++- optuna_dashboard/ts/action.ts | 4 ++-- optuna_dashboard/ts/components/AppDrawer.tsx | 7 ++++++- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/optuna_dashboard/_app.py b/optuna_dashboard/_app.py index a0be6770..318135b0 100644 --- a/optuna_dashboard/_app.py +++ b/optuna_dashboard/_app.py @@ -192,7 +192,7 @@ def create_app( @json_api_view def get_study_detail(study_id: int) -> dict[str, Any]: # Use the following default values if not specified in request.params. - query_params = dict(after=0, limit=1000) + query_params = dict(after=0, limit=2000) for query_key in query_params: try: query_params[query_key] = int(request.params[query_key]) @@ -235,6 +235,7 @@ def create_app( plotly_graph_objects = get_plotly_graph_objects(system_attrs) skipped_trial_ids = get_skipped_trial_ids(system_attrs) skipped_trial_numbers = [t.number for t in trials if t._trial_id in skipped_trial_ids] + limit = len(trials) if limit == 0 else limit fetched_trials_partially = after + limit < len(trials) return serialize_study_detail( summary, diff --git a/optuna_dashboard/ts/action.ts b/optuna_dashboard/ts/action.ts index a54e09ea..159e22fe 100644 --- a/optuna_dashboard/ts/action.ts +++ b/optuna_dashboard/ts/action.ts @@ -235,9 +235,9 @@ export const actionCreator = () => { }) } - const updateStudyDetail = (studyId: number) => { + const updateStudyDetail = (studyId: number, forceFetchAllTrials: boolean = false) => { let nLocalFixedTrials = 0 - const nMaximumTrialsAtOnce = 2000 + const nMaximumTrialsAtOnce = forceFetchAllTrials ? 0 : 2000 if (studyId in studyDetails) { const currentTrials = studyDetails[studyId].trials const firstUpdatable = currentTrials.findIndex((trial) => diff --git a/optuna_dashboard/ts/components/AppDrawer.tsx b/optuna_dashboard/ts/components/AppDrawer.tsx index 31eeec69..0c17f338 100644 --- a/optuna_dashboard/ts/components/AppDrawer.tsx +++ b/optuna_dashboard/ts/components/AppDrawer.tsx @@ -310,7 +310,12 @@ export const AppDrawer: FC<{ { - action.saveReloadInterval(reloadInterval === -1 ? 10 : -1) + const newReloadInterval = reloadInterval === -1 ? 10 : -1 + action.saveReloadInterval(newReloadInterval) + if (newReloadInterval === -1) { + const forceFetchAllTrials = true + action.updateStudyDetail(studyId, forceFetchAllTrials) + } }} >