From 7ae1e4f3713fe851c2fd59cdcbab3dd136d02ebb Mon Sep 17 00:00:00 2001 From: porink0424 Date: Fri, 5 Apr 2024 11:56:26 +0900 Subject: [PATCH] Replace null -> undefined in trial.values to support type --- tslib/storage/src/journal.ts | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tslib/storage/src/journal.ts b/tslib/storage/src/journal.ts index 911d2d10..81d48bc4 100644 --- a/tslib/storage/src/journal.ts +++ b/tslib/storage/src/journal.ts @@ -289,7 +289,7 @@ class JournalStorage { return } thisTrial.state = trialStateNumToTrialState(log.state) - thisTrial.values = log.values + thisTrial.values = log.values === null ? undefined : log.values thisTrial.datetime_start = log.datetime_start ? new Date(log.datetime_start) : undefined @@ -350,21 +350,21 @@ const loadJournalStorage = (arrayBuffer: ArrayBuffer): Optuna.Study[] => { escapedLog = escapedLog.replace(/-Infinity/g, '"***-inf***"') escapedLog = escapedLog.replace(/Infinity/g, '"***inf***"') return JSON.parse(escapedLog, (_key, value) => { - switch (value) { - case "***nan***": - return NaN - case "***-inf***": - return -Infinity - case "***inf***": - return Infinity - default: - return value - } - }) + switch (value) { + case "***nan***": + return NaN + case "***-inf***": + return -Infinity + case "***inf***": + return Infinity + default: + return value + } + }) } } })() - + switch (parsedLog.op_code) { case JournalOperation.CREATE_STUDY: journalStorage.applyCreateStudy(parsedLog as JournalOpCreateStudy)