From 7e1685946a58656b8f3ee48679d429aee1cf70dd Mon Sep 17 00:00:00 2001
From: c-bata <contact@c-bata.link>
Date: Fri, 9 Apr 2021 16:31:14 +0900
Subject: [PATCH] Add visual improvements of pareto front

---
 .../static/components/GraphParetoFront.tsx         | 12 +++++++++---
 optuna_dashboard/static/components/StudyDetail.tsx | 14 +++++++-------
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/optuna_dashboard/static/components/GraphParetoFront.tsx b/optuna_dashboard/static/components/GraphParetoFront.tsx
index b2d861d0..f23dc32d 100644
--- a/optuna_dashboard/static/components/GraphParetoFront.tsx
+++ b/optuna_dashboard/static/components/GraphParetoFront.tsx
@@ -6,6 +6,7 @@ import {
   FormLabel,
   MenuItem,
   Select,
+  Typography,
 } from "@material-ui/core"
 import { createStyles, makeStyles, Theme } from "@material-ui/core/styles"
 
@@ -13,10 +14,12 @@ const plotDomId = "graph-pareto-front"
 
 const useStyles = makeStyles((theme: Theme) =>
   createStyles({
+    title: {
+      margin: "1em 0",
+    },
     formControl: {
       marginBottom: theme.spacing(2),
       marginRight: theme.spacing(5),
-      marginTop: theme.spacing(10),
     },
   })
 )
@@ -51,6 +54,9 @@ export const GraphParetoFront: FC<{
       {study !== null && study.directions.length !== 1 ? (
         <Grid item xs={3}>
           <Grid container direction="column">
+            <Typography variant="h6" className={classes.title}>
+              Pareto Front
+            </Typography>
             <FormControl component="fieldset" className={classes.formControl}>
               <FormLabel component="legend">Objective X ID:</FormLabel>
               <Select value={objectiveXId} onChange={handleObjectiveXChange}>
@@ -74,7 +80,7 @@ export const GraphParetoFront: FC<{
           </Grid>
         </Grid>
       ) : null}
-      <Grid item xs={6}>
+      <Grid item xs={9}>
         <div id={plotDomId} />
       </Grid>
     </Grid>
@@ -95,9 +101,9 @@ const plotParetoFront = (
     return
   }
   const layout: Partial<plotly.Layout> = {
-    title: "Pareto-front plot",
     margin: {
       l: 50,
+      t: 0,
       r: 50,
       b: 0,
     },
diff --git a/optuna_dashboard/static/components/StudyDetail.tsx b/optuna_dashboard/static/components/StudyDetail.tsx
index 47541c65..f2e9b2c7 100644
--- a/optuna_dashboard/static/components/StudyDetail.tsx
+++ b/optuna_dashboard/static/components/StudyDetail.tsx
@@ -183,6 +183,13 @@ export const StudyDetail: FC = () => {
               <GraphHistory study={studyDetail} />
             </CardContent>
           </Card>
+          {studyDetail !== null && !isSingleObjectiveStudy(studyDetail) ? (
+            <Card className={classes.card}>
+              <CardContent>
+                <GraphParetoFront study={studyDetail} />
+              </CardContent>
+            </Card>
+          ) : null}
           {studyDetail !== null && isSingleObjectiveStudy(studyDetail) ? (
             <Grid container direction="row">
               <Grid item xs={6}>
@@ -236,13 +243,6 @@ export const StudyDetail: FC = () => {
               </CardContent>
             </Card>
           ) : null}
-          {studyDetail !== null && !isSingleObjectiveStudy(studyDetail) ? (
-            <Card className={classes.card}>
-              <CardContent>
-                <GraphParetoFront study={studyDetail} />
-              </CardContent>
-            </Card>
-          ) : null}
           <Card className={classes.card}>
             <TrialTable studyDetail={studyDetail} />
           </Card>